Неllo!

We tried to use the 6.x-2.6 version of your wunderfull module, but we found an annoying bug.

In the click_heatmap.js file, we found an extra bracket in row 6:

Drupal.behaviors.click_heatmap = function()) {

must be:

Drupal.behaviors.click_heatmap = function() {

Thanks!

CommentFileSizeAuthor
#4 click_heatmap-extra-parenthesis-611596-4.patch390 bytesmrconnerton

Comments

danielcala’s picture

danielcala commented

I found the same error, and that is the solution, remove the extra parenthesis.

Thanks a lot

bu5hm4nn’s picture

bu5hm4nn commented

Yup, it's in there, and it's an error. Remove the extra parenthesis.

philbar’s picture

philbar commented
Title: Wrong click_heatmap.js » Extra parenthesis in click_heatmap.js
Status: Active » Reviewed & tested by the community

Please remove.

mrconnerton’s picture

mrconnerton commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new click_heatmap-extra-parenthesis-611596-4.patch390 bytes

I have attached a patch.

hadsie’s picture

hadsie commented
Status: Needs review » Reviewed & tested by the community

This works for me. Thanks @mrconnerton.

john franklin’s picture

john franklin commented

Has this really been a bug for 2.5 years? (Works here, too.)

boombatower’s picture

boombatower commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks.

I do not maintain this any more so if someone else wants to take over please ask (just clicked on this by random).

john franklin’s picture

john franklin commented

Sure, I'll take it over. I'm going to need a D7 version of this module in the next few months, anyway.

boombatower’s picture

boombatower commented

Sounds good. Added you as maintainer.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.