Closed (fixed)
Project:
Facebook-style Statuses (Microblog)
Version:
6.x-2.0-rc2
Component:
Code - Functionality
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
22 Oct 2009 at 15:40 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent
Comments
Comment #1
icecreamyou commentedThe original way I did it used Regex, which is about a zillion times better than the current string-based implementation (and would fix this problem) except that some people had problems with it due probably to server configuration issues. I'd like to switch back to Regex entirely, but I will probably just add an option to use it instead.
Comment #2
icecreamyou commentedI'm having some trouble getting the regex to work with unicode. I opened a forum topic on a PHP Regex board though, and once I get an answer there the rest is fairly trivial.
Comment #3
pheraph commentedThanks for your instant response. I'd be glad if that issue could be fixed.
Comment #4
icecreamyou commentedI just committed a fix to CVS that completely switches to Regex. I didn't leave an option for the string-based method because it was too restrictive. The new parsing:
[#hello world]now matches the tag#hello worldwhere it previously would only have matched#hello.Comment #5
pheraph commentedHi,
thanks that works very well so far. We just noticed that dashes in tags (#hash-tag f.e.) don't work:
http://fbss.icecreamyou.com/statuses/term/hash-tags
I hope you're able to fix that, too.
Regards,
Raphael
Comment #6
icecreamyou commented[#hash-tag] works, but #hash-tag doesn't. I'm going to keep it that way since a hyphen is a word-break character and Twitter doesn't accept hashtags with hyphens either.
Comment #7
icecreamyou commentedActually, #hash-tag seems to work too, but I think Views might have a problem with the hyphen character in arguments or something like that... will look into it.
Comment #8
icecreamyou commentedYeah, it turns out that Views has a bug with taxonomy term name arguments where the term name has a hyphen in it. There's not much I can do about that, unfortunately.
Comment #9
pheraph commentedSo what would be the next step? I might post an issue at the views module, but as you seem to have an idea what the problem might be, maybe you want to?
Thx so far!
Raphael
Comment #10
icecreamyou commentedI have no idea what the actual problem is, I just asked on IRC. There's probably already an issue open in the Views queue, and if not that's likely the best way to go.