Sending subscription notifications on "Blocked content types"

Break9 - October 22, 2009 - 16:35
Project:Subscriptions
Version:6.x-1.1
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

My site is now sending notifications on "Blocked content types" to all users subscribed to a taxonomy term, when a new node is created with that taxonomy present even though it is on the "Blocked content types"

#1

salvis - October 22, 2009 - 23:13
Component:subscriptions_event» Code
Status:active» needs work

Now that I look at it, I don't think this has ever worked right. Are you implying it did work in BETA5?

#2

Break9 - October 22, 2009 - 23:24

yes it worked for me since Dec 2008 when I first added this module.

#3

salvis - October 23, 2009 - 00:24

I also thought it worked, but I cannot find any code in BETA5 (nor 1.1) that would actually do make it work...

#4

Break9 - October 23, 2009 - 00:52

Yep, it has worked great for the last year until I updated. I have thousands of users that are affected by the change. they all noticed immediately. Hence me in a deep pile of ___.

Any and all help is appreciated on both issues.

#5

Break9 - October 23, 2009 - 01:34

here is the complete working as expected version of subscriptions I had on my site. Niether this nor the http://drupal.org/node/610106 issues are present in the version. zip is attached

The only code changes i made were:

subscriptions.taxonomy.module;
********remove the words "to content in"

subscription.module;
$items['user/%user/subscriptions/'. $stype] = array(
'title' => $data['title'],
********'type' => MENU_CALLBACK,
'file' => 'subscriptions.admin.inc',
'page callback' => 'subscriptions_page',
'page arguments' => array(1, $stype),
'access callback' => '_subscriptions_access',
'access arguments' => array(1, $data['access']),
'weight' => (isset($data['weight']) ? $data['weight'] : 0),
);

AttachmentSize
subscriptions.zip 140.99 KB

#6

salvis - November 3, 2009 - 22:42
Status:needs work» fixed

I've committed a fix to the -dev version (give it up to 12h to be repackaged).

Please let us know if this works for you now.

(Unfortunately, I don't know what to do about your other issue...)

#7

Break9 - November 3, 2009 - 22:50

I will test and report back.

Yes, the other issue is very strange? i don't know why it doesn't want the $account parameter passed to the function call. It is unfortunate since that is the primary interface for this module on our site. I will have to use the older release until I can sort out what is happening.

Thanks for the update on this issue, and the module in general it is great!!

#8

System Message - November 17, 2009 - 23:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.