Posted by ac on October 22, 2009 at 6:35pm
| Project: | Hosting |
| Version: | 6.x-0.4-alpha2 |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Minor stuff
| Attachment | Size |
|---|---|
| hosting_general_cleanup.patch | 1003 bytes |
Comments
#1
#2
This has actually become a fairly large patch but the file is now very neat. Minor changes needed to eldir which are coming next.
#3
Attached a new patch for above and include the eldir patch instead of opening a new issue there.
#4
at the very least the block css still needs to be there in hosting (ie: blocks floated left and right).
it's an important part of providing a usable system out of the box regardless of theme
http://skitch.com/vertice/nrj1k/mytest.dev-t
versus
http://skitch.com/vertice/nrj1c/mytest.dev-t
#5
I don't think not floating stuff stops it being usable. I agree its not as pretty but that is why aegir has eldir. Floating stuff makes creating your own theme harder and may cause potential problems with other themes due to the nature of floats. If you wrapped the task list and the platform/site info in a classed div then we could float stuff with more confidence:
<div class="hosting-info-wrapper clear-block"><div class="hosting-site-info" />
<div class="hosting-task-list" />
</div>
#6
modified for latest HEAD
#7
commited
#8
Automatically closed -- issue fixed for 2 weeks with no activity.