Minor stuff

CommentFileSizeAuthor
#6 hosting_cleanup.patch4.7 KBac
#3 remove_css_cruft(2).patch4.49 KBac
#3 eldir_mods.patch1.77 KBac
#2 remove_css_cruft.patch4.47 KBac
hosting_general_cleanup.patch1003 bytesac

Comments

ac’s picture

ac
Primary language English
Location Perth
commented
Status: Active » Needs review
ac’s picture

ac
Primary language English
Location Perth
commented
StatusFileSize
new remove_css_cruft.patch4.47 KB

This has actually become a fairly large patch but the file is now very neat. Minor changes needed to eldir which are coming next.

ac’s picture

ac
Primary language English
Location Perth
commented
StatusFileSize
new eldir_mods.patch1.77 KB
new remove_css_cruft(2).patch4.49 KB

Attached a new patch for above and include the eldir patch instead of opening a new issue there.

adrian’s picture

adrian commented
Status: Needs review » Needs work

at the very least the block css still needs to be there in hosting (ie: blocks floated left and right).

it's an important part of providing a usable system out of the box regardless of theme

http://skitch.com/vertice/nrj1k/mytest.dev-t

versus

http://skitch.com/vertice/nrj1c/mytest.dev-t

ac’s picture

ac
Primary language English
Location Perth
commented

I don't think not floating stuff stops it being usable. I agree its not as pretty but that is why aegir has eldir. Floating stuff makes creating your own theme harder and may cause potential problems with other themes due to the nature of floats. If you wrapped the task list and the platform/site info in a classed div then we could float stuff with more confidence:

<div class="hosting-info-wrapper clear-block">
<div class="hosting-site-info" />
<div class="hosting-task-list" />
</div>
ac’s picture

ac
Primary language English
Location Perth
commented
StatusFileSize
new hosting_cleanup.patch4.7 KB

modified for latest HEAD

ac’s picture

ac
Primary language English
Location Perth
commented
Status: Needs work » Fixed

commited

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.