Add method to allow requests to additional Solr servelets (paths)
pwolanin - October 22, 2009 - 19:18
| Project: | Apache Solr Search Integration |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Description
For the attachements module and other added functionality it would be nice to add the facility to easily post (and request?) data to different paths in addition to the ones defined in the classes.
#1
Something like this - would be useful for the attachements module to POST multi-part form data
#2
Slightly revised - needed for: http://drupal.org/node/490078
#3
+++ apachesolr.module 25 Oct 2009 18:01:11 -0000@@ -1041,6 +1041,10 @@ function apachesolr_facetcount_save($edi
+ if (empty($query)) {
+ // This should only happen if Solr is not set up - avoids fatal errors.
+ return;
+ }
Sneaking something in? Well, I suppose it's a good idea.
Regarding the function, it's okay with me, but smells like cut-and-paste. Perhaps the available handlers should be defined in an array or something so they can be modified through some public method?
Anyway, if it's a pain to refactor, it's not a very difficult thing to fix later.
-J
I'm on crack. Are you, too?
#4
The method we took already to add additional handlers was to extend the class from the PHP library via the Drupal module and add new methods. It just won't work to have each additional contrib module try to do that, so this can be a more generic approch for module to interact with customized response handlers. We should probably add a matching GET method?
#5
Here's a little more refined method that allows any type of request.
#6
Final version w/ tweaked doxygen
committing this to 6.x-1.x
#7
committing attached to 6.x-2.x
#8
port to 5.x?
#9
Yes. Here's the patch...
#10
Uppps... Sorry, forgot the patch.
#11
Committed in #284512.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.