New panel-pane.tpl.php breaks $content->links backwards compatibility.

Posted by jonskulski on October 22, 2009 at 9:11pm

Issue Summary

I'm actually not sure if this is a bug or not, but I would assume it's an oversight.

In the new panel-pane.tpl.php preprocess (line 1035) function it is defined

<?php 

$vars['links'] = !empty($content->links) ? implode(' ', $content->links) : '';

?>

WHERE AS, in display-render.inc in theme function (panels 3.0)

<?php

$output .= "<div class=\"links\">" . theme('links', $content->links) . "</div>\n";

?>

Posted by jonskulski on October 22, 2009 at 9:12pm

Status:

active

» needs review

Here is a patch that runs $content->links through theme('links')

Attachment	Size
panels-612116.patch	817 bytes

Posted by merlinofchaos on January 12, 2010 at 11:16pm

Status:

needs review

» fixed

I remember wondering about that when I committed it. I should have checked more carefully.

Posted by System Message on January 26, 2010 at 11:20pm

Status:

fixed

» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.