Posted by serenecloud on October 23, 2009 at 4:05am
Jump to:
| Project: | Email Field |
| Version: | 6.x-1.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
| Issue tags: | diff |
Issue Summary
The diff module has a default implementation which expects cck types to store their values in $item['value']. This is not the case for email, which uses $item['email'].
Ideally email would use 'value' however until then I have written a patch that implements hook_content_diff_values() instead and uses the 'email' value.
| Attachment | Size |
|---|---|
| email_diff.patch | 644 bytes |
Comments
#1
This patch is 6 weeks old and nothing has happened - can a maintainer please review?
#2
We're have this issue as well. Haven't tried the patch yet.
#3
Applied the patch and it works like a charm.
-Daniel
#4
Hey there, I just installed the latest dev version of this module, but still I can't seem to see the diff for the email field, would there be anything special to do?
For what version of diff is this done?
I use the : 6.x-2.0 and the latest dev from this module, and still no luck seeing the diffs!
Thanks for any help,
Alexis
#5
Thanks for this patch. Works perfectly.
By the way, it's really bad practice, but I just pasted the code in a custom module for easier maintenance. I had to use a patch for the link module too, plus one custom code for a special field of mine, so it started to become unbearable.
#6