the address field won't show

warning: Parameter 1 to theme_addresses_elements() expected to be a reference, value given in /path-to-drupal/includes/theme.inc on line 617.

CommentFileSizeAuthor
#7 addresses_state_php5-3.patch1.37 KBcodycraven
#6 addresses_php5-3_fix.patch738 bytescodycraven

Comments

boftx’s picture

boftx commented
Issue tags: +PHP 5.3

I fully agree with the Priority being "Critical".

I have the same issue at work, running Drupal 6.14, PHP 5.3, Apache 2 under Solaris 9 on Sparc hardware. This problem is directly caused by PHP5.3 not being fully backwards compatible (again!!!!) and is present is several other modules. We are going to uninstall PHP 5.3 and load 5.2.x instead for now, but that is going to be unacceptable over time. Also, I host several sites running Drupal 6.14 on Bluehost and when they upgrade (and I use the term loosely) to 5.3 I won't have the option to revert.

Please look into this ASAP.

codycraven’s picture

codycraven commented
Priority: Critical » Minor
Status: Active » Postponed

PHP 5.3 should absolutely be supported. However Drupal 6 does not support PHP 5.3 at this time and thus this is a low priority issue. Currently there are a lot of usability features that are of a much higher priority as they cripple the use of the module.

codycraven’s picture

codycraven commented
Priority: Minor » Critical
Status: Postponed » Active

Turns out Drupal, as of 6.14, supports PHP 5.3. This issue is now marked as active.

codycraven’s picture

codycraven commented

This has been fixed.

The issue was being caused by theme_addresses_elements() requiring the first parameter to be a reference value which in 5.3 is not being passed and thus throws an error. By removing the reference requirement the module functions normally as no modifications to the parameter are performed within the theme_addresses_elements() function.

codycraven’s picture

codycraven commented
Status: Active » Fixed
codycraven’s picture

codycraven commented
StatusFileSize
new addresses_php5-3_fix.patch738 bytes

Just discovered an error with PHP 5.3 when editing an Addresses field in CCK. The fix for this is nearly identical to the previous fix but for the theme_addresses_settings_fields().

codycraven’s picture

codycraven commented
Title: php 5.3 error » Remove hook_theme references on parameters
Category: bug » task
StatusFileSize
new addresses_state_php5-3.patch1.37 KB

Found two more issues, this should fix all of these types of issues as none of the hook_theme functions have referenced parameters now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

fawksfeather’s picture

fawksfeather commented
Assigned: Unassigned » fawksfeather
Status: Closed (fixed) » Needs review

Hi, i think i am having a similar problem but not too familiar with how specifically to fix this, I'm running drupal 6.14 and when I click on Create New Account, the following warning appears:

warning: Parameter 1 to theme_addresses_elements() expected to be a reference, value given in /data/18/1/81/3/1081981/user/1124724/htdocs/includes/theme.inc on line 617.

I think removing reference requirement may fix it but i'm not exactly what needs to be removed or in what file. hopefully someone is still around to read this post! Thank you!

AlexisWilke’s picture

AlexisWilke commented

You may want to consider upgrading at least to Drupal 6.24 for security reasons...

Have you tried with the development version? Because I cannot see a problem in the current source.

Thank you.
Alexis

AlexisWilke’s picture

AlexisWilke commented
Status: Needs review » Active

Note that the "Needs review" status is for when you offer a patch. 8-)

fawksfeather’s picture

fawksfeather commented

Hi Alexis, thank you for your advice!! i actually gave up looking for a solution and i'm attempting to upgrade to 6.25 as I type this :D
and thanks for the status input, i'm a newbie to this as you can see, thanks again!