Doesn't work with a display:block links / in menu items

BarisW - October 23, 2009 - 09:09
Project:External Links
Version:6.x-1.8
Component:Code
Category:support request
Priority:normal
Assigned:Unassigned
Status:by design
Description

The js code checks if an has a line display. If so, it wraps a span around it with the class ext. If not, the ext class is added to the tag itself. However, extlink.css only contains a icon background for span.ext and span.mailto, not for a.ext and a.mailto.

I have some links in my site with display:block (some CCK Links in my sidebar for example). On these links, the icon does not appear.

#1

BarisW - October 23, 2009 - 09:11

Apologies, forgot to add <code> blocks...

The js code checks if an <a> has a display:inline display. If so, it wraps a span around it with the class ext. If not, the ext class is added to the <a> tag itself. However, extlink.css only contains a background-image for span.ext and span.mailto, not for a.ext and a.mailto

I have some links on my site with display:block (some CCK Links in my sidebar for example). On these links, the icon does not appear.

#2

quicksketch - October 23, 2009 - 15:08

This is intentional, since often times links are display: block because they have a background image or are part of the primary navigation or tabs.

#3

RaiMan - November 12, 2009 - 20:11
Title:Doesn't work with a display:block links» Doesn't work with a display:block links / in menu items

Don't know wether same problem:
in menu items: ext link is recognized (opens in new window) but icon is not attached.

#4

quicksketch - November 13, 2009 - 01:19
Category:bug report» support request

in menu items: ext link is recognized (opens in new window) but icon is not attached.

Yes this is probably because your theme uses display: block for displaying menu items in your navigation.

As I noted above, this is by design.

#5

RaiMan - November 14, 2009 - 13:13
Status:active» by design

Thanks.

I just started with drupal and for my intentions your module is a must.

Using standard Garland, because my priority is functionality in the moment.

I've reset status to 'by design', but it would be great to get an answer, wether there will be a chance to get a solution for that or not.

 
 

Drupal is a registered trademark of Dries Buytaert.