Download & Extend

__history__.html and url-aliases

Project:Exhibit
Version:6.x-1.0-beta1
Component:Miscellaneous
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

there is an issue with the loading of the __history__.html file when you use an alias for the node where the exhibit is. The exhibit javascript is always looking for the __history__.html file in the current folder, which normally is node/__history__.hmtl - but when you use an alias the url would be different obviously.

the same problem occurs when you use parameters like node/232/?args=12 -- then it is looking for node/232/__history__.html

what would be the best solution to solve this issue?

ps: this issue seems to be a problem in particular with the TILE VIEW.

greets,
walter

ps: interesting post on google groups about the purpose of the __history__.html http://tinyurl.com/yhg7ax5

Comments

#1

just add this to the .module file after line 69

'node/%node/__history__.html' => array(
'type' => MENU_CALLBACK,
'access arguments' => array('access exhibits'),
'page callback' => 'exhibit_output_history',
'file' => 'exhibit.pages.inc',
),
'__history__.html' => array(
'type' => MENU_CALLBACK,
'access arguments' => array('access exhibits'),
'page callback' => 'exhibit_output_history',
'file' => 'exhibit.pages.inc',
),

i hope i can provide a patch as well, but have to get CVS client first.

#2

Status:active» needs review

attached the patch.

its my first for drupal, so please give hints if something is not correct.

ps: the issue seems to be in particular severe for safari on windows (i have version 4.0.3)

best,
walter

AttachmentSize
exhibit.module.patch 1 KB

#3

#4

I finally got around to finding a solution for this, and I applied the above patch. It didn't work, so it occurred me that maybe it was because I have friendly-urls enabled. I tried to modify one of the bits to match my url, but that didn't seem to work either. I have pasted below the patch with my modification (in the middle). Am I missing something?

/* patch: http://drupal.org/files/issues/exhibit.module.patch */
    'node/%node/__history__.html' => array(
      'type' => MENU_CALLBACK,
      'access arguments' => array('access exhibits'),
      'page callback' => 'exhibit_output_history',
      'file' => 'exhibit.pages.inc',
    ),
'resources/publications-and-syllabi/__history__.html' => array(
  'type' => MENU_CALLBACK,
  'access arguments' => array('access exhibits'),
  'page callback' => 'exhibit_output_history',
  'file' => 'exhibit.pages.inc',
),
    '__history__.html' => array(
      'type' => MENU_CALLBACK,
      'access arguments' => array('access exhibits'),
      'page callback' => 'exhibit_output_history',
      'file' => 'exhibit.pages.inc',
    ),
/* end patch */

Thanks,
Maria