theme_get_function() 5->6 upgrade suggestion to theme_get_registry() is confusing
jhodgdon - October 23, 2009 - 17:00
| Project: | Coder |
| Version: | 6.x-2.x-dev |
| Component: | Review/Rules |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Description
Someone filed this issue #250420: theme_get_registry() doc is confusing
The issue reported is that they were confused by the theme_get_registry() doc -- which I'm adding a patch for.
But the reason they were looking at theme_get_registry() in the first place was because of this Coder 5.x-6.x check on their module, in includes/coder_6x.inc:
function _coder_6x_theme_get_function_warning() {
return t('!theme_get_function() has been deprecated because of template theming; see !theme_get_registry()',
array(
'!theme_get_function' => theme('drupalapi', 'theme_get_function', '5'),
'!theme_get_registry' => theme('drupalapi', 'theme_get_registry', '6'),
)
);
}I'm wondering if it might make more sense to point someone who was using theme_get_function() in a module to just use theme() rather than pointing them to theme_get_registry()? Or maybe in addition? It seems like there's no good reason to use theme_get_function() in Drupal 6? But maybe I am missing something...