Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
system.module
Priority:
Critical
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
23 Oct 2009 at 17:22 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
catchPatch isn't pretty, but removes the fatal errors. #585628: Cannot use update.php as anonymous user prevents testing beyond this for the overall upgrade, but at least no wsod with this one.
Comment #2
sun1) Couldn't we simply disable/skip path alias lookups when defined('MAINTENANCE_MODE') ?
2) If not 1), could we move the contents of that update into the d7 requirements function?
Comment #3
catchFor #1 unless we add !defined(MAINTENANCE_MODE) to every path lookup no, I'd rather keep the ugliness in update.php
For #2, the d7_requirements munging shouldn't leave you in a state where you can't revert to D6, so we can't rename columns there.
Comment #4
webchickI talked this over with catch on IRC. I also can't really envision a more svelte way to handle this. This moves ugly code to update.php as opposed to the critical path (+1) and doesn't automatically start converting anything just by virtue of visiting this page (also +1).
As a side note, it seems pretty odd that if you bootstrap to DRUPAL_BOOTSTRAP_LANGUAGE you still have to manually include unicode.inc. :P But obviously not for this patch to solve.
Committed to HEAD. Thanks!