Closed (fixed)
Project:
Drupal core
Version:
7.x-dev
Component:
toolbar.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Oct 2009 at 18:37 UTC
Updated:
3 Jan 2014 at 00:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
effulgentsia commentedHere's the patch. In running benchmarks, I also discovered that in a situation where the anonymous user has access to the toolbar (admittedly, unlikely), warnings are triggered when building the "Hello USERNAME" link. This patch solves that by building a different link, more appropriate to an anonymous user.
The benchmark I ran was a fresh install of HEAD with the default profile, adding a single node of the Page type (title = "Title", body = "Body"), and enabling all permissions for the anonymous user. I also created and enabled a dummy module whose only code is:
With this setup, on my computer (running MAMP, so not a production server), running "ab -c1 -n100 http://localhost:8888/d7/node/1", I got:
HEAD + just the last 2 hunks of this patch (needed to turn off PHP notices): 93.0 +/- 2.1
HEAD + full patch: 89.0 +/- 2.2
Comment #2
moshe weitzman commentedCode and benchmarks look good.
Comment #3
webchickYum! Thanks! Committed to HEAD. :)
Comment #4
yched commentedApplied to #563562: Batch API pages should not show the toolbar