Posted by alexjarvis on October 23, 2009 at 8:59pm
| Project: | NineSixty (960 Grid System) |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
The official 960gs release has added an alternative 24 column version. Any plans to add to NineSixty?
Comments
#1
Sure, why the hell not? If the official release has it, I'll make sure it has the same.
It would also make sense to have a 4th version of the styles.
1.) 12 columns
2.) 16 columns
3.) combined 12 & 16 columns
4.) 24 columns
Even though the 24 column styles would encompass the 12/16 combined styles, I'm pretty sure keeping a separate version would still be slimmer.
#2
Here is a patch that implements support fpr the 24 column version that comes with the original library. I've added the 24 column layout to the existing
960.css. I think it makes sense to have them all in the same file.Things that are still missing:
I'd be glad to implement those things once I know if this has the potential to be committed.
#3
...And here is the patch :)
#4
My vote for 24 column version.
#5
dixon_, thanks for the patch. As to css, it seems to work fine.
#6
dixon_, your patch does not have .container-24 .pull-19 or .container-24 .push-5
was there a reason or just an oversight?
#7
Thanks for the patch dixon. I don't think it should be merged with the main 960.cs file. It should be separated into it's own 24 column version like it's done in the main 960.gs distribution. I was working on it but I remember this being a problem when there are multiple styles to choose from the base theme so there needs to be additional logic.
I'll try getting this up soon.
#8
The 6.x-1.x-dev branch has the 24 column version amongst a few other changes. To select it you have to set it through a .info setting from your sub-theme. This was done this way since it's impossible to enable a style living in the base theme from a sub-theme and I thinks this is very straight forward.
From the README.txt:
I also improved the debug styles. To enable it set this through .info in your sub-theme:
settings[960 debug] = 1The 960.gs templates bundled with the original grid framework has also been updated. You'll see them in the "extras" folder. There may be something I've missed but the README.txt should cover it.
And lastly, a few extra functions were added to enable the .info settings. If you wanted, you could use them for your own purposes. Reading through the code should give you some ideas.
The download link may take a while before it's packaged with the new changes.
#9
How to use mixture of 12 & 16 columns in template?
#10
Automatically closed -- issue fixed for 2 weeks with no activity.