See topic.

CommentFileSizeAuthor
#2 nodewords_drop_backup_table-D6.patch568 byteshass

Comments

hass’s picture

Additonally db_query("DELETE FROM {variable} WHERE name LIKE 'nodewords%'"); will delete external nodewords_* module variables, too. If someone on d.o writes a nodewords_foo module and have nodewords settings the uninstall will kill this variables, too and may make other modules unusable.

nodewords_nodetype could be such a candidate... (currently no data loss, but possible)

hass’s picture

Status: Active » Needs review
StatusFileSize
new568 bytes

Patch attached for removal of backup table.

avpaderno’s picture

Status: Needs review » Closed (works as designed)

The table nodewords_10 has been intentionally left, and it contains the table has it was in the version 6.x-1.0 of the module.
The table will be removed from the update function for version 6.x-1.3.

hass’s picture

Status: Closed (works as designed) » Needs review

If I'd like to get rid of all my nodewords stuff this table need to be removed. If you'd like to keep it for now and remove it in 7.x I'm fine to keep it. I'm only saying - if the module has intentionally *uninstalled* - everything in my database need to be cleaned out and there is no need to keep stale tables.

I may do not like to re-install nodewords any-time later...

avpaderno’s picture

Title: Uninstall does not remove the backup table "nodewords_10" » Remove backup table "nodewords_10"
Category: bug » task
Status: Needs review » Fixed

If you'd like to keep it for now and remove it in 7.x

See my previous comment; it was not my intention to keep it until the version for Drupal 7.

The code has been changed, and committed in CVS.

hass’s picture

I would suggest to keep the table for one release more (let's say half a year)... maybe there are more broken settings you need to recover. And with the kept table you are always able to recover with an update function later in 1.4 or so... otherwise if you are able to assure by 100000% that nothing is lost - remove it now.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.