The disable shipping option not respected on certain attributes
RikiB - October 24, 2009 - 14:00
| Project: | Ubercart |
| Version: | 6.x-2.2 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Description
I just upgraded from the latest beta to the full version yesterday.
Now Ubercart doesn't respect the option to disable Shipping on a certain attribute, so when someone wants to buy a download only they are being charge shipping and are required to put their shipping info at checkout.
This was working before the upgrade, I double checked my settings and something is definitely wrong. Would anyone have any idea how to get this fixed asap??
#1
Try giving issues a title that have some meaning to the actual issue.
#2
noted, thanks. Hoping for a solution, Ive tried a lot of things to work around this but currently I just put a $0 Shipping option for now.
#3
I just did a lot more testing and I cant find a workaround, I hope its a simple patch. Any help would be greatly appreciated.
#4
I know I sound very annoying by now, but I guess I learned a good lesson about testing before upgrading.
Anyway I went through the trouble of installing a fresh copy of drupal and the problem is indeed real and confirmed on this test site.
#5
I have no idea why this isnt getting any attention, I mean..do I stink or something? :p
Any hope for a patch or anything?
#6
bumping in hopes that someone can confirm or deny this huge bug.
#7
Tracked down the problem to a particular change made in #574066: Object-valued by-reference parameters in Ubercart - Trouble with PHP 5.3 call_user_func_array. This patch should fix the problem so that shippable, non-shippable, and mixed orders will cause the delivery address and shipping panes to appear when they should.
#8
I don't believe it! That patch is the antichrist!
Definitely just kidding. :-/
#9
Wow. Took me a long time to see what you were talking about. :P
#10
Thank you, thank you, thank you! Seems to work perfectly.
#11
Great. Committed.
#12
Automatically closed -- issue fixed for 2 weeks with no activity.
#13
I have to reopen this because its not completely fixed unfortunately. So I just upgraded to 2.2 to make sure and this is fixed it seems for 90% of the time. But for some crazy reason 10% of the time when someone buys download only, they are forced to put in their shipping information and also choose a shipping option (exactly the problem I state at the very top).
I know it doesnt make any sense but this is happening everyday with tons of people, but it doesnt happen everytime. Is there any hope??
For the time being Im putting a $0 shipping option until this is fixed, but it does confuse some customers.
Thanks.
#14
At this point, I don't see how I can help if I don't know what's causing the problem. Can you duplicate the issue yourself, or is it just some of your customers? Is it possible that some of your file products don't have their shippable flags set correctly? Check both the main edit form for the product and for the file features. If that doesn't help, add some debug statements around the area of code that the patch modified. Use the dpm() function from the Devel module to the check the return values of hook_cart_item().