I get the following message when clicking Save on admin/settings/wysiwyg if I haven't made any changes.

warning: Invalid argument supplied for foreach() in C:\HostingSpaces\priory01\support.priorysolutions.com\wwwroot\sites\all\modules\wysiwyg\wysiwyg.admin.inc on line 485.

I have wysiwyg 6.x-2.x from 24th-Oct-09. I only have a single editor (ckeditor) and a single input type (full html). I didn't get any problems when deleting my previous editor and then adding ckeditor so that's what makes me think it's just when I haven't made any changes.

Saving the preferences for CKEditor works fine.

CommentFileSizeAuthor
#6 wysiwyg-DRUPAL-6--3.php-warning.patch1.31 KBsun
#2 wysiwyg_patch_1.patch326 bytesterryprogetto

Comments

brightbold’s picture

brightbold
she/her
Primary language English
Location Boston, MA
commented

I was able to reproduce this (without even trying!) using 6.x-2.x-dev from 11/8, and also with CKeditor. I agree it seems only to happen if no changes have been made.

terryprogetto’s picture

terryprogetto commented
StatusFileSize
new wysiwyg_patch_1.patch326 bytes

Here is my patch for this problem.

twod’s picture

twod
Primary language Swedish
Location Sweden
commented
Status: Active » Needs work

Thanks for the patch. We took a different approach in 7.x-3.x-dev where the Save button is excluded if no formats can be changed, and we should also port the rest of the GUI improvements from there back to 6.x-2.x-dev.

Btw, we usually create patches using the -up switches so it includes more context and is easier to review. ;)

terryprogetto’s picture

terryprogetto commented

You are welcome and besides, this is my second patch at drupal.org and a few days of using CVS)

twod’s picture

twod
Primary language Swedish
Location Sweden
commented

I hope you understood I did not mean that comment to sound negative in any way. (I suck at telling how people react to things online...) I made a mess out of my first patches (and I still often do), just trying to help others do better.

Welcome to the world of patching, CVS and module development! We need all the help we can get so I hope you like creating patches, we need a lot of them all over the place hehe.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs work » Fixed
StatusFileSize
new wysiwyg-DRUPAL-6--3.php-warning.patch1.31 KB

Thanks for reporting, reviewing, and testing! Committed attached patch to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.