After upgrading from 6.x-1.7 :
The external Link and Mail icons aren't displayed in IE6 and IE7 (Works on IE 8 and FF 3.5)

CommentFileSizeAuthor
#8 613964_ie_icon_fix.patch975 bytesdeviantintegral

Comments

Morn’s picture

Priority: Normal » Critical

Moved to critical

VivekDubey’s picture

Status: Active » Fixed

Edit extlink.css and add property “zoom: 1;” in both the rules.


span.ext {
  background: url(extlink.png) right center no-repeat;
  padding-right: 12px;
  zoom: 1;
}
span.mailto {
  background: url(mailto.png) right center no-repeat;
  padding-right: 12px;
  zoom: 1;  
}

I think new update should be released with this inclusion, although the issue is resolved and can be closed.

quicksketch’s picture

Priority: Critical » Normal
Status: Fixed » Needs review

Hah, funny thing. We actually removed zoom thanks to extensive whining by standards-purists.

#495682: zoom property not valid CSS
#402778: Zoom: 1 Is Not Valid CSS
#527170: Invalid CSS
#411848: External Links css validation errors

I was rather assured that removing it had no negative affect, but apparently that wasn't the case. I'll set this back to needs review so I can include it after some testing in the next release.

Morn’s picture

It works. Tested in IE6 + 7 +8 , FF 3.5 and Google Chrome

VivekDubey’s picture

It seems IE is finally following the standards in IE8. ;-)

Anonymous’s picture

phew - fix worked for me.
Thanks.

deviantintegral’s picture

Version: 6.x-1.8 » 6.x-1.x-dev
StatusFileSize
new975 bytes

Better yet, why not use jQuery to apply the property only for IE? That way the CSS is still valid, and the images work in IE. The attached patch sets zoom: 1; for IE < 8. It uses browser versions as AFAICT nothing in jQuery.support matches this bug.

quicksketch’s picture

Hmm, we can't use $.browser.msie, since that property doesn't exist in jQuery 1.3 (I believe) and it was deprecated in 1.2.

deviantintegral’s picture

According to http://docs.jquery.com/Utilities/jQuery.browser it's better to use the $.support functionality, but that $.browser won't be removed (presumably to handle cases such as this where none of the support tests are TRUE or FALSE for IE6/7 but not 8).

quicksketch’s picture

Status: Needs review » Fixed

For the time being I just added zoom: 1 again. It works.

deviantintegral’s picture

Works for me - thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.