dynamic default role load needed for consistency
miro_dietiker - October 25, 2009 - 14:00
| Project: | OG User Roles |
| Version: | 6.x-4.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Jump to:
Description
Since "Default role for new group administrators" and "Default role for new group members" are not configurable per group, i don't see any reason to store them in the ogur table.
Much more i would recommend to create the assignment adhoc.
As long as ogur doesn't offer any way to rebuild user assignments, results are wrong after any update.
Attached patch considers adhoc default and admin default role based on configuration and group context.
| Attachment | Size |
|---|---|
| ogur_adhoc.patch | 1.43 KB |
#1
I do not see a bug report here.
Please also make sure to read http://drupal.org/coding-standards, your code needs work either way. However, before continuing with coding, please provide a proper bug report first. What did you do? What did you expect? What did happen? What did not happen?
#2
The initial bug report is:
Make groups, add some admins
Add an ogur role "Group X Admin". Make it default group administrator. Previously added group admins will lack the default group admin role. Also OGUR doesn't provide a way to rebuild default group roles (leading to heavy consistency problems).
I don't see any need for Admin and Member roles to be persisted. If we assign them adhoc, they won't have a chance to get wrong.
OK, the patch lacks some coding-standards. But it should allow you to understand the thoughts. I'll work another iteration on it, but i kindly ask for some feedback/inputs about these concepts and thoughts.