Perhaps I'm crazy, but doesn't every form generating function need to have $form, &$form_state as the arguments?
When going to admin/config/modules/install I receive the following error:
Warning: Parameter 1 to update_manager_install_form() expected to be a reference, value given in drupal_retrieve_form() (line 496 of includes/form.inc).
The current definition is:
function update_manager_install_form(&$form_state) {
But it needs to be fixed to be:
function update_manager_install_form($form, &$form_state) {
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 614026-2.update-manager-install-form.patch | 1.11 KB | dww |
| #1 | update-manager-install-form-614026-1.patch | 969 bytes | johnalbin |
Comments
Comment #1
johnalbinThis patch fixes the bug and adds the missing docblock for this function.
Comment #2
dwwThat's very strange -- I wonder why I don't see those errors. But yeah, that looks like a good fix. However, while we're changing this, we should also fix the fact that when this form builder is invoked from the menu system, we also pass in a 3rd argument, $context. Added that to the function signature and PHPDoc.
Thanks, John!
p.s. We're tagging all Update-manager-related issues with "Update manager" so we can track them all together -- even though most are in update.module component, some are spread around in other places, so the tag is helpful.
Comment #3
chx commentedThat's a good one.
Comment #4
dries commentedCommitted to CVS HEAD. Thanks.