Download & Extend
Issues

Node UI text improvements to author display settings

Posted by lisarex on October 25, 2009 at 11:21pm
Project:Drupal core
Version:7.x-dev
Component:node.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:D7UX, ui-text

Issue Summary

Clarification of UI text on the author display settings at admin/structure/types/manage/[content type]

Login or register to post comments

Comments

#1

Posted by lisarex on October 25, 2009 at 11:24pm
Status:active» needs review

See attached before and after screenshots, and patch.

AttachmentSizeStatusTest resultOperations
afterDisplayAuthoring.png24.4 KBIgnored: Check issue status.NoneNone
beforeDisplayAuthoring.png18.07 KBIgnored: Check issue status.NoneNone
cckui_614324.patch698 bytesIdlePassed: 14680 passes, 0 fails, 0 exceptionsView details

#2

Posted by lisarex on October 26, 2009 at 1:05am
Title:Field UI text improvements to author display settings» Node UI text improvements to author display settings
Component:field_ui.module» node.module

#3

Posted by lisarex on October 26, 2009 at 2:04am
Assigned to:lisarex» Anonymous

#4

Posted by Bojhan on October 26, 2009 at 5:08am

Perhaps just chaning the label? Can anyone provide feedback on how dynamic it is?

#5

Posted by heather on November 21, 2009 at 1:51pm

This is an improvement, yet, when the display isn't selected it doesn't make sense.

This is when you have de-selected the option and saved the configuration and returned to this:

display-whennotselected.png

Suggested improvement:

Instead to read "If selected, author username and publish date will be displayed."

display-suggestion.png

AttachmentSizeStatusTest resultOperations
display-whennotselected.png41.01 KBIgnored: Check issue status.NoneNone
display-suggestion.png12.05 KBIgnored: Check issue status.NoneNone
displayauthorname.patch940 bytesIdlePassed on all environments.View details

#6

Posted by Dries on November 21, 2009 at 2:03pm

+++ modules/node/content_types.inc 21 Nov 2009 13:41:22 -0000
@@ -205,9 +205,9 @@
-    '#title' => t('Display post information'),
+    '#title' => t('Display post author information'),

To me, 'post author information' sounds a little funny -- the word 'post' feels redundant in its/the context. How about 'Display authoring information' or just 'Display author and date information'? The latter is the most accurate, I guess.

#7

Posted by redndahead on November 21, 2009 at 2:26pm

This is with dries suggestion for language.

AttachmentSizeStatusTest resultOperations
disply_info-614324-1.patch945 bytesIdlePassed on all environments.View details

#8

Posted by lisarex on November 21, 2009 at 2:40pm

Yes this patch looks good to me! See attached for 'after' screenshot.

AttachmentSizeStatusTest resultOperations
Page | Drupal 7 Working Copy for Dev_1258814405351.png15.69 KBIgnored: Check issue status.NoneNone

#9

Posted by heather on November 21, 2009 at 2:47pm

Apparently my initial suggestions were not on the mark...

Bojhan: nearlythere: We want to avoid (if selected) kind of things
Bojhan: nearlythere: boolean language, should not live in the interface.
Bojhan: nearlythere: .... in general we try to avoid boolean language.

So this is lisarex's original change + dries's suggestion.

display-fixes.png

AttachmentSizeStatusTest resultOperations
displayauthorname2.patch932 bytesIdlePassed on all environments.View details
display-fixes.png11.72 KBIgnored: Check issue status.NoneNone

#10

Posted by Bojhan on November 21, 2009 at 3:54pm
Status:needs review» reviewed & tested by the community

Looks good.

#11

Posted by webchick on November 21, 2009 at 5:44pm
Status:reviewed & tested by the community» fixed

Committed to HEAD! Thanks!

#12

Posted by System Message on December 5, 2009 at 5:50pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here