Download & Extend
Issues

UI text improvements to 'Delete' content type confirmation message

Posted by lisarex on October 26, 2009 at 12:35am
Project:Drupal core
Version:7.x-dev
Component:node.module
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:#d7ux, ui-text

Issue Summary

UI text on admin/structure/types/manage/[content type]/delete could be easier to understand.

Login or register to post comments

Comments

#1

Posted by lisarex on October 26, 2009 at 1:00am

I cleaned it up a bit, following best practices outlined at [#604342]

Forgot to get a 'before' example screenshot of the text when the content type contains a single post but it's very similar to the plural version.

AttachmentSizeStatusTest resultOperations
beforeDeleteContentTypePlural.png20.57 KBIgnored: Check issue status.NoneNone
afterDeleteContentTypePlural.png20.44 KBIgnored: Check issue status.NoneNone
afterDeleteContentTypeSingular.png19.14 KBIgnored: Check issue status.NoneNone
cckui_614358.patch1.19 KBIdlePassed: 14715 passes, 0 fails, 0 exceptionsView details

#2

Posted by lisarex on October 26, 2009 at 1:03am
Component:field_ui.module» node.module

#3

Posted by lisarex on October 26, 2009 at 2:02am
Title:Field UI text improvements to 'Delete' content type confirmation message» UI text improvements to 'Delete' content type confirmation message
Assigned to:lisarex» Anonymous
Status:active» needs review

#4

Posted by lisarex on October 27, 2009 at 9:54pm

Per your comments in IRC, I've revised the text. Better?

So I deleted a content type that had nodes associated with it to see what would happen. When editing one of those nodes I see:

* Notice: Undefined index: listing_node_form in drupal_retrieve_form() (line 469 of /Users/lisa/web/d7/includes/form.inc).
* Warning: call_user_func_array(): First argument is expected to be a valid callback, 'listing_node_form' was given in drupal_retrieve_form() (line 496 of /Users/lisa/web/d7/includes/form.inc)."

So clearly they cannot delete content types unless they also want to delete or basically forget about editing the nodes also.

In IRC you suggested having an extra line break between the text and the button, which I agree would look better, but this hasn't been done in the other places I looked (such as deleting a taxonomy at admin/structure/taxonomy/2)

AttachmentSizeStatusTest resultOperations
uitext_614358_4.patch1.25 KBIdlePassed: 14700 passes, 0 fails, 0 exceptionsView details
afterDeleteContentTypePlural2.png19.52 KBIgnored: Check issue status.NoneNone
afterDeleteContentTypeSingular2.png19.28 KBIgnored: Check issue status.NoneNone

#5

Posted by Bojhan on November 8, 2009 at 1:19am

We might want to add some spacing. A between cannot be undone and the previous sentence, and between the button? Gave a try at it with a patch.

AttachmentSizeStatusTest resultOperations
uitext_614358_4.patch1.27 KBIdlePassed: 14660 passes, 0 fails, 0 exceptionsView details

#6

Posted by Dries on November 8, 2009 at 7:19pm
Status:needs review» fixed

Committed to CVS HEAD. I committed lisa's patch in #4 because we shouldn't hardcode line breaks in the t() strings. We can follow up with a spacing patch if necessary. Thanks Lisa and Bojhan.

#7

Posted by System Message on November 22, 2009 at 7:20pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.