UI text on admin/structure/types/manage/[content type]/delete could be easier to understand.

CommentFileSizeAuthor
#5 uitext_614358_4.patch1.27 KBBojhan
#4 uitext_614358_4.patch1.25 KBlisarex
#4 afterDeleteContentTypePlural2.png19.52 KBlisarex
#4 afterDeleteContentTypeSingular2.png19.28 KBlisarex
#1 beforeDeleteContentTypePlural.png20.57 KBlisarex
#1 afterDeleteContentTypePlural.png20.44 KBlisarex
#1 afterDeleteContentTypeSingular.png19.14 KBlisarex
#1 cckui_614358.patch1.19 KBlisarex

Comments

lisarex’s picture

lisarex commented
StatusFileSize
new cckui_614358.patch1.19 KB
new afterDeleteContentTypeSingular.png19.14 KB
new afterDeleteContentTypePlural.png20.44 KB
new beforeDeleteContentTypePlural.png20.57 KB

I cleaned it up a bit, following best practices outlined at #604342: Interface text

Forgot to get a 'before' example screenshot of the text when the content type contains a single post but it's very similar to the plural version.

lisarex’s picture

lisarex commented
Component: field_ui.module » node.module
lisarex’s picture

lisarex commented
Title: Field UI text improvements to 'Delete' content type confirmation message » UI text improvements to 'Delete' content type confirmation message
Assigned: lisarex » Unassigned
Status: Active » Needs review
lisarex’s picture

lisarex commented
StatusFileSize
new afterDeleteContentTypeSingular2.png19.28 KB
new afterDeleteContentTypePlural2.png19.52 KB
new uitext_614358_4.patch1.25 KB

Per your comments in IRC, I've revised the text. Better?

So I deleted a content type that had nodes associated with it to see what would happen. When editing one of those nodes I see:

* Notice: Undefined index: listing_node_form in drupal_retrieve_form() (line 469 of /Users/lisa/web/d7/includes/form.inc).
* Warning: call_user_func_array(): First argument is expected to be a valid callback, 'listing_node_form' was given in drupal_retrieve_form() (line 496 of /Users/lisa/web/d7/includes/form.inc)."

So clearly they cannot delete content types unless they also want to delete or basically forget about editing the nodes also.

In IRC you suggested having an extra line break between the text and the button, which I agree would look better, but this hasn't been done in the other places I looked (such as deleting a taxonomy at admin/structure/taxonomy/2)

Bojhan’s picture

Bojhan commented
StatusFileSize
new uitext_614358_4.patch1.27 KB

We might want to add some spacing. A between cannot be undone and the previous sentence, and between the button? Gave a try at it with a patch.

dries’s picture

dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. I committed lisa's patch in #4 because we shouldn't hardcode line breaks in the t() strings. We can follow up with a spacing patch if necessary. Thanks Lisa and Bojhan.

Status: Fixed » Closed (fixed)
Issue tags: -ui-text, -#d7ux

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +ui-text, +#d7ux

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.