Feed categories aren't "remembered"

Steve Dondley - May 2, 2006 - 18:14
Project:Aggregator2
Version:HEAD
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:needs review
Description

1) Create a feed and save it in a category
2) The next time you go to edit the feed, the category is listed as "none"

#1

Steve Dondley - May 2, 2006 - 19:19
Status:active» closed

This problem was caused by me. I had the vocabulary set to "feed item" and not "feed".

#2

Steve Dondley - May 2, 2006 - 19:27

Ugh, this is confusing. This bug does, in fact, apply to the "item categories" selection.

#3

Steve Dondley - May 2, 2006 - 19:28
Status:closed» active

#4

Steve Dondley - May 3, 2006 - 12:58
Priority:critical» normal
Status:active» needs review

Here's a patch.

AttachmentSize
aggregator2.patch 1.06 KB

#5

hintbw - May 10, 2006 - 18:00

Tested this patch on 4.7 final (with clean urls on) and it keeps the items category information and applies to new feed items. +1 for committing the patch

#6

bkark - May 14, 2006 - 01:46

I applied the patch but am still having problems when trying to select multiple feed item categories...it's only saving one of the categories. It looks like the one being saved is the first selected category in the list.

#7

srodriguez - May 22, 2006 - 13:42
Priority:normal» critical
Status:needs review» needs work

I am having the same problem with 4.7. It adds the tags the first time around but when the feed is updated afterwards the tags for each feed item don't show up unless I manually update each feed, which won't work since my new site revolves around tags. I tried the patch and it seemed to make the feed item tags disappear from the feed edit page. I am trying to figure out why the first time it works and gives the appearance of working well but then breaks after cron runs.

#8

Richard Eriksson - June 22, 2006 - 05:33
Status:needs work» reviewed & tested by the community

livvylove: that's a separate issue, which is at http://drupal.org/node/62794

I tested the patch offered and it fixes this issue, that is feeds not remembering which category. +1 for committing.

#9

Steve Dondley - July 7, 2006 - 12:15
Status:reviewed & tested by the community» needs work

I just discovered this patch does not work with vocabularies that have multi-select taxonomy structures. In other words, it only works with feeds that are assigned to one single term.

#10

Steve Dondley - July 7, 2006 - 12:57
Status:needs work» needs review

OK, this patch seems to work on feeds with more than one term associated with them and even with more than one term across different vocabularies.

Beyond that, I have not tested to see if it works with synonymous terms and other advanced taxonmy hierarchies.

AttachmentSize
aggregator2_form.patch 624 bytes

#11

Richard Eriksson - July 14, 2006 - 14:24

That last patch requires the patch before it. Here's a combined patch against the CVS version (that is I applied the first patch, then the second patch, and got a diff from the CVS version of aggregator2.module) which seems to work with both a single taxonomy term and multiple terms.

AttachmentSize
aggregator2-remember-feed-taxonomy.patch.txt 1.49 KB

#12

Steve Dondley - July 14, 2006 - 15:32

Oops. Thanks for backing me up, Richard.

#13

jivyb - August 22, 2006 - 18:08

Could someone post a file that has the complete agg2 patched module code? (not just the diff/patch)

Thanks!

#14

Ron Williams - September 2, 2006 - 21:50

Attached is the patched file

AttachmentSize
aggregator2_2.module 86.66 KB
 
 

Drupal is a registered trademark of Dries Buytaert.