Download & Extend
Pathauto » Issues

Auto alias fails with some content types

Posted by izmeez on October 26, 2009 at 2:47pm
Project:Pathauto
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

I have reverted to using pathauto 6.x-1.dev (2009 Oct 08) to solve this problem.

In 6.x-1.2 and the current version the auto alias is not active when new content is created. This does not occur with all content types. In many the auto alias is active. However, with Support module tickets it was not the case.

Testing different versions of the Support module makes no difference. However, reverting to the earlier pathauto dev solves the problem.

This problem is significant because new tickets and possibly other content created will require url alias to be updated.

Thanks,

Izzy

Login or register to post comments

Comments

#1

Posted by brad.bulger on October 26, 2009 at 10:05pm

it looks to me that this is caused by the way it tests to see if this is a new node:

if (isset($node->nid)) {

this will test as TRUE if $node->nid is 0 (only NULL fails isset()). changing it to

if (!empty($node->nid)) {

makes the checkbox come up checked when creating a node.

zero vs NULL in nid may be something about the content type - in my case, it's a CCK content type that comes from a feature, that may be an issue.

AttachmentSizeStatusTest resultOperations
pathauto.isset_.patch597 bytesIgnored: Check issue status.NoneNone

#2

Posted by izmeez on October 29, 2009 at 6:34pm
Status:active» needs review

Brad,

Thanks. The patch works. I have changed status to needs review. Hope that's the right thing to do.

Izzy

#3

Posted by izmeez on December 12, 2009 at 9:55pm
Status:needs review» reviewed & tested by the community

ok, as I novice it is probably my own fault this has not moved forward to a commit.

I have tested the latest pathauto dev 2009-12-06 and the same problem exists.
I applied the patch and it works.

I am changing the status to "reviewed and tested by the community" to move this forward to commit.

Thanks,

Izzy

#4

Posted by Dave Reid on December 12, 2009 at 9:59pm
Version:6.x-1.2» 6.x-1.x-dev

Makes sense. I agree with the RTBC. Should also be applied to the 6.x-2.x branch.

#5

Posted by PepeMty on December 14, 2009 at 4:03pm

Hello everybody!
I'm using 6.x-2.x-dev (2009-Dic-05) and have the same problem, only it's happening with all content types.

Guess that patch won't work with my version, right?

Warm regards from sunny México!
:-)
Pepe

#6

Posted by izmeez on December 14, 2009 at 6:26pm

Try it and report back. It's only one line, you can do it manually. Thanks,

Izzy

#7

Posted by lelizondo on December 14, 2009 at 7:24pm

is not working for me, I'm using 6.x-1.2.

The checkbox is selected, but pathauto won't generate a new alias.

#8

Posted by izmeez on December 14, 2009 at 8:10pm

@lelizondob

Can you please clarify. Is the patch not working for you on 6.x-1.2 ?

Thanks,

Izzy

#9

Posted by lelizondo on December 14, 2009 at 8:33pm

yes, the patch didn't work with 6.x-1.2. I just didn't want to move the issue's version

#10

Posted by izmeez on December 14, 2009 at 10:50pm

Have you tried testing with the latest dev release and the patch? It has worked for us.

Thanks,

Izzy

#11

Posted by lelizondo on December 14, 2009 at 11:38pm

No, I will do that.

#12

Posted by lelizondo on December 15, 2009 at 5:10am
Status:reviewed & tested by the community» needs work

I've tried with 6.x-1.x-dev and it's not working, the checkbox is selected but pathauto isn't generating the alias, not even on bulk update.

Maybe this has something to do with something else.

Moving the status till someone can confirm this is actually working and I'm just a weird case.

#13

Posted by lelizondo on December 15, 2009 at 5:19am

I'm using 6.x-1.1 now and is working.

#14

Posted by izmeez on December 15, 2009 at 5:35am

Did you apply the patch automagically or manually? It may be that the patch needs a new diff to identify the correct line number for the change.

#15

Posted by PepeMty on December 15, 2009 at 3:26pm

Re #5 & #6
Yep! I did it manually, and it did the trick... ;-)

Thanks so much, really!

Warmest regards from sunny México!
:-)
Pepe

#16

Posted by greggles on December 15, 2009 at 8:47pm

@lelizondob it sounds like your problem is somewhat unrelated.

#17

Posted by izmeez on December 15, 2009 at 9:06pm

Can the status of this be changed back to RTC ?

#18

Posted by lelizondo on December 15, 2009 at 9:09pm

@greggles Probably, but I don't know where to start looking since pathauto 6.x-1.1 is working

#19

Posted by izmeez on December 15, 2009 at 9:10pm

@lelizondob - Can you describe your problem in more specific detail? Thanks,

#20

Posted by lelizondo on December 15, 2009 at 9:57pm

@izmeez I don't know what else to tell you, the 'Create automatic alias' checkbox is selected, pathauto is properly configured, but pathauto won't generate the alias, when using pathauto 6.x-1.1 everything works smoothly.

I'll try to path the file manually and see what happens. I saw the release notes of 6.x-1.2 and I saw most of the changes were translations, any particular issue or change that could be affecting this so I could check it out, please let me know. I'll be willing to test since this is such an important module for many sites.

#21

Posted by Summit on January 4, 2010 at 2:28pm

Hi,

Confirmation this is working also on version Pathauto 6.x-2.x-dev (2009-Dec-06).
After changing this one line of code the automatic alias was checked again!
So please also change this line in new Pathauto 6.x-2.x-dev version.

Thanks a lot in advance.
greetings,
Martijn

#22

Posted by izmeez on January 4, 2010 at 6:22pm
Status:needs work» reviewed & tested by the community

I am not a maintainer of this module but found this fix essential so I have again changed the status back to RTBC.

Thanks,

Izzy

#23

Posted by garbo on February 8, 2010 at 2:10pm

I noticed that pathauto and the "node-as-block" module don't work well together.

see: http://drupal.org/node/707956

#24

Posted by greggles on February 10, 2010 at 9:27pm
Status:reviewed & tested by the community» fixed

Now fixed in 6.x-1.x-dev, 6.x-2.x-dev, 7.x-1.x-dev
http://drupal.org/cvs?commit=326996
http://drupal.org/cvs?commit=326998
http://drupal.org/cvs?commit=327000

Thanks everyone!

#25

Posted by System Message on February 24, 2010 at 9:30pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#26

Posted by interestingaftermath on August 27, 2010 at 7:50pm
Status:closed (fixed)» active

Has this item been fixed in the 6.x-1.4 release? I am experiencing this exact issue in 6.x-1.4. When I edit a node that has not been aliased, the Automatic alias option is not selected by default.

Sorry for opening the issue back up... I'm not sure if that's what you're supposed to do or not.

#27

Posted by Dave Reid on August 27, 2010 at 7:54pm
Status:active» fixed

@interestingaftermath: Can you please file a new issue detailing exactly what's going wrong for you instead of opening tickets that have been closed for several months or years?

#28

Posted by interestingaftermath on August 27, 2010 at 8:07pm

Sigh... I sure will. It's hard to know what format each dev wants their issues organized. Some want to keep all issues grouped, some want new issues for issues related this items from months ago. A bit confusing indeed :)

#29

Posted by System Message on September 10, 2010 at 8:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.