Hi

I noticed that list of recipients on the top of message is shorter as it is on the bottom of message.
In my concrete example, on the top there is 20 recipients, but on the bottom of message there is 41 recipients.

Please note, I am using Berdir submodule for adding/forward new recipents into the message, I don't know if it has some influence for it.

thanks
Igor

CommentFileSizeAuthor
#3 privatemsg.show_all.patch949 bytesberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

That is more or less a feature, not a bug, atleast for the limited display of 20 recipients at the top, see http://blog.worldempire.ch/api/function/_privatemsg_format_participants/1.

The "and others." part is displayed, right?

We should probably limit the list at the bottom too.

igorik’s picture

igorik commented

Hi Berdir

thanks for the quick reply.
I haven't "and others" in top list of recipients.

However, IMO at least on one place in the message is needed to show ALL recipients. It could be very important information for a lot of people they want to know who is in the participants of some message and/or how is number of recipients.
I think the best solution could be to show some short list of recipients, but after the list to show something like link "show everybody" which display the rest. (unhide, or it load them by ajax, or whatever)

So My two cents - I definitely vote for showing ALL recipients at least on the bottom of the message (at least until somebody don't create some nice solution how to unhide all recipients after click on link) and for adding "and others" into top list of recipients.

Igor

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new privatemsg.show_all.patch949 bytes

All participants are loaded anyway, so the attached patch displays all of them. We need to handle it differently I think but for now, this should be ok.

Note that this does not result in a lot of queries because they are not fully loaded user objects, just uid and name. However, if you use realname.module or another one that requires the full user object it might result in a lot of additional queries.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Needs review » Fixed

Fixed in 6.x-1.x-dev and 7.x-1.x-dev.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.