Flag trim using Rules Doesn't Work
hga77 - October 26, 2009 - 18:29
| Project: | Flag |
| Version: | 6.x-2.x-dev |
| Component: | Rules integration |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Amitaibu |
| Status: | closed |
Description
This functionality does not work!!! Unless I'm missing something.
I've installed:
- Flag 6.x-2.x-dev (and applied last patch from http://drupal.org/node/596564)
- Rules 6.x-1.1
I have a content type that has a Flag ('Featured' flag). I need to be able to set a limit to the number of flags I can set. I need a maximum of 6 'Featured' items. So i've set the rule (look at the attached image). But this doesnt work.
Something that would have taken me 1 minute to implement is taking me more that 3 hrs and no result...
Please help since I want to use Flag/Rules combo
| Attachment | Size |
|---|---|
| Editing rule When featuring Case Study, limit flags - momentumww uk_1256580975382.png | 20.5 KB |
#1
Attached is the flags setup page
#2
I don't support the Rules module implementation, this will remain unfixed unless a patch is provided.
#3
It states on the Flag module page "Full Rules module integration"
I'm trying to use Trim Flag.
#4
The Rules integration was written by the community and our previous maintainer mooffie. Unfortunately mooffie is no longer working on Drupal, so there are no maintainers that support the Rules integration directly. It's included in the 1.1 version because community members wrote it. If it's not updated I'll remove it from the 2.x version.
#5
Ok, thanks for the details.
#6
Just a note that Amitaibu regularly contributes to Flag and has been keeping up with all the 2.x changes, I don't think he'll allow the 2.x version to actually loose the Rules integration.
#7
> don't think he'll allow the 2.x version to actually loose the Rules integration.
Indeed :)
I'll have a look at this issue in a couple of days. I know for sure it worked for 6.x-1.0, need to check what has changed.
#8
Just confirming flag 6.x-1.1 and rules 6.x-1.1 continue to work. so definitely change from 1.0 to 1.1 did NOT cause this.
#9
Patch fixes trim (we passed the user ID instead of the user object). Also remove whitespaces.
#10
Thanks, looks good to me. The change from $uid to $account makes sense, considering that we need the full $account anyway to pass into the flag() function. Committed.
#11
Great thanks guys :)
#12
Automatically closed -- issue fixed for 2 weeks with no activity.