Download & Extend
Issues

Remove overlay-related cruft from toolbar module

Posted by ksenzee on October 26, 2009 at 7:36pm
Project:Drupal core
Version:7.x-dev
Component:toolbar.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:overlay

Issue Summary

D7: .to-overlay is not used anymore as a trigger to open the overlay but is kept in toolbar module still; our patch should remove that obsolete code

Login or register to post comments

Comments

#1

Posted by David_Rothstein on December 7, 2009 at 5:48am
Title:Overlay D7: remove cruft from toolbar module» Remove overlay-related cruft from toolbar module
Component:other» toolbar.module

Retitling.

#2

Posted by casey on January 15, 2010 at 6:38pm
Status:active» needs review
AttachmentSizeStatusTest resultOperations
toolbaroverlay.patch1.5 KBIdlePassed on all environments.View details

#3

Posted by marcvangend on March 7, 2010 at 12:25am
Status:needs review» needs work

The patch makes total sense, but after applying the toolbar links are left with an empty class attribute, for instance:

<a title="Select and configure your themes" id="toolbar-link-admin-appearance" href="http://localhost/d7/node#overlay=admin/appearance" class=""><span class="icon"></span>Appearance <span class="element-invisible">(Select and configure your themes)</span></a>

I couldn't really figure out where it comes from, can it be removed?

#4

Posted by casey on April 6, 2010 at 12:14pm
Status:needs work» needs review

Reroll.

Issue that @marcvangend mentioned seems to be fixed already.

AttachmentSizeStatusTest resultOperations
toolbaroverlay.patch1.67 KBIdlePASSED: [[SimpleTest]]: [MySQL] 19,054 pass(es).View details

#5

Posted by casey on May 14, 2010 at 12:17pm

Anyone?

#6

Posted by Dries on May 14, 2010 at 4:52pm
Status:needs review» fixed

Yes, me! Committed to CVS HEAD. Thanks.

#7

Posted by System Message on May 28, 2010 at 5:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.