Download & Extend
Issues

Implement .overlay-displace-bottom

Posted by ksenzee on October 26, 2009 at 8:18pm
Project:Drupal core
Version:7.x-dev
Component:overlay.module
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

D6: overlay-displace-top was implemented but not overlay-displace-bottom, so stuff displayed at the bottom (like the contrib l10n_client module) will roll above or behind the toolbar possibly

Login or register to post comments

Comments

#1

Posted by David_Rothstein on December 7, 2009 at 5:47am
Title:Overlay D6: implement .overlay-displace-bottom» Implement .overlay-displace-bottom
Component:other» overlay.module

Is this still an issue?

Looks like there is an overlay-displace-bottom in the code, but it only appears once - I don't have time now to check if that's a complete implementation or not.

#2

Posted by casey on December 23, 2009 at 10:56pm

If it was it isn't there any more. I'll provide a patch...

#3

Posted by aspilicious on January 17, 2010 at 1:12pm

Still an issue?

#4

Posted by aspilicious on January 26, 2010 at 7:10pm

Bump... Can I close this or not?

#5

Posted by ksenzee on January 26, 2010 at 7:12pm

No, this is still an active issue.

#6

Posted by casey on February 6, 2010 at 12:58pm
Status:active» needs review

Attached patch should make it work. Also replaced "displaced regions" with "displaced elements" for clarity; The word "region" means something else in Drupalsh.

AttachmentSizeStatusTest resultOperations
overlay-displace-bottom.patch3.75 KBIdlePASSED: [[SimpleTest]]: [MySQL] 18,730 pass(es).View details

#7

Posted by aspilicious on March 5, 2010 at 5:57pm

ksenzee or others can you review this?

#8

Posted by cosmicdreams on March 15, 2010 at 3:27pm

#6: overlay-displace-bottom.patch queued for re-testing.

#9

Posted by casey on June 8, 2010 at 5:53pm
Status:needs review» fixed

Included in #668640: Overlay shouldn't be based on jQuery UI Dialog.

We still need a generic solution though: #787940: Generic approach for position:fixed elements like Toolbar, tableHeader.

#10

Posted by System Message on June 22, 2010 at 6:00pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.