Admin Role - Permissions and Sync module with D7-implementation for upgrading ease.

azz - October 26, 2009 - 22:20
Project:Admin Role
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Dave Reid
Status:fixed
Description

Would it be posable in the next version to add permission control that would allow an admin user of a site the ability to decide which roles have access to the administration page for the Admin Role module, currently any user that has access to administration pages can access and change the Admin Role.

Thanks,
From: Azz McH

#1

azz - November 4, 2009 - 18:09
Title:Permission Controls» Permission Controls using Admin Role module
Status:active» needs review

#2

Dave Reid - November 25, 2009 - 02:34

Seems fair that the 'administer users' should be the permission for the adminrole page. This would match the D7 behavior:

  $items['admin/config/people/accounts'] = array(
    'title' => 'Account settings',
    'description' => 'Configure default behavior of users, including registration requirements, e-mails, and user pictures.',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('user_admin_settings'),
    'access arguments' => array('administer users'),
    'file' => 'user.admin.inc',
    'weight' => -10,
  );

#3

Dave Reid - November 25, 2009 - 02:34
Status:needs review» active

No patch = active

#4

Dave Reid - November 25, 2009 - 03:24
Title:Permission Controls using Admin Role module» Sync module with D7-implementation for upgrading ease.
Version:6.x-1.1» 6.x-1.x-dev
Category:feature request» task
Assigned to:Anonymous» Dave Reid

People should be able to upgrade from D6 + adminrole.module to plain D7 without losing functionality. That will entail:

1. Moving the admin role select box to the admin/user/settings page and getting rid of the page callbacks.
2. Renaming the adminrole_adminrole variable to user_admin_role.
3. Other misc cleanups.

AttachmentSize
615336-adminrole-D7sync-D6.patch 5.05 KB

#5

Dave Reid - November 25, 2009 - 03:52
Status:active» needs review

#6

DanielTheViking - November 25, 2009 - 07:57

As discussed here;
"Adminrole security hole: admins can assign themselves full permissions"
http://drupal.org/node/375954#new
- this is not only for "upgrading ease".

#7

Dave Reid - November 25, 2009 - 15:49
Status:needs review» fixed

Fixed in CVS.

#8

azz - November 25, 2009 - 17:08
Title:Sync module with D7-implementation for upgrading ease.» Admin Role - Permissions and Sync module with D7-implementation for upgrading ease.

All I want to know is, will this be fixed in a new release? Including http://drupal.org/node/375954.

#9

Dave Reid - November 25, 2009 - 17:38

Yes it will.

#10

azz - November 25, 2009 - 18:06

Good, when will the new release be available?

#11

Dave Reid - November 25, 2009 - 18:39

When I'm finished? Probably later today.

#12

azz - November 25, 2009 - 18:45

Great

#13

Dave Reid - November 25, 2009 - 21:11

New releases created.

 
 

Drupal is a registered trademark of Dries Buytaert.