phone.eg.inc

agharbeia - October 26, 2009 - 23:12
Project:Phone (CCK)
Version:HEAD
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs review
Issue tags:egypt, telephone
Description

Sub-module for Egypt telephones.

AttachmentSize
phone.es_.inc_.test1.89 KB

#1

thierry_gd - October 27, 2009 - 14:06

There are a lot of reference to Spain in the file : some cleaning of the code need to be done !!!

#2

agharbeia - October 27, 2009 - 14:15

My stupid!
I simply attached the wrong file. You know, Eg => Es!
Attaching the correct one here.

AttachmentSize
phone.eg_.inc_.test 4.4 KB

#3

thierry_gd - October 27, 2009 - 14:40

After the line "Regional area codes" there are a lot of signs (????) :

القاهرة الكبرى 2
الإسكندرية 3
القليوبية 13
العاشر من رمضان 15
الغربية

What are they ?
Some cleaning need to be done !

#4

thierry_gd - October 27, 2009 - 14:42

After the line "Regional area codes" there are a lot of signs (????) :

القاهرة الكبرى 2
الإسكندرية 3
القليوبية 13
العاشر من رمضان 15
الغربية

What are they ?
Some cleaning need to be done !

#5

thierry_gd - October 27, 2009 - 22:01
Status:active» needs work

#6

agharbeia - October 28, 2009 - 22:36

That's Arabic text encoded in UTF-8. Your editor probably didn't guess that.
It's a brief area codes' guide, the names are locales in Egypt. It's part of the comments explaining the RegEx.

#7

agharbeia - October 31, 2009 - 11:57
Version:6.x-2.9» HEAD
Status:needs work» needs review

changing status

#8

thierry_gd - November 5, 2009 - 14:11

Taken into account in 6.2.11 release

#9

agharbeia - November 9, 2009 - 20:48

a fix in one RegEx instance: 4 digits instead of 3

AttachmentSize
phone.eg_.inc_.diff 282 bytes
 
 

Drupal is a registered trademark of Dries Buytaert.