Sub-module for Egypt telephones.

CommentFileSizeAuthor
#9 phone.eg_.inc_.diff282 bytesagharbeia
#2 phone.eg_.inc_.test4.4 KBagharbeia
phone.es_.inc_.test1.89 KBagharbeia

Comments

thierry_gd’s picture

thierry_gd commented

There are a lot of reference to Spain in the file : some cleaning of the code need to be done !!!

agharbeia’s picture

agharbeia commented
StatusFileSize
new phone.eg_.inc_.test4.4 KB

My stupid!
I simply attached the wrong file. You know, Eg => Es!
Attaching the correct one here.

thierry_gd’s picture

thierry_gd commented

After the line "Regional area codes" there are a lot of signs (????) :

القاهرة الكبرى 2
الإسكندرية 3
القليوبية 13
العاشر من رمضان 15
الغربية

What are they ?
Some cleaning need to be done !

thierry_gd’s picture

thierry_gd commented

After the line "Regional area codes" there are a lot of signs (????) :

القاهرة الكبرى 2
الإسكندرية 3
القليوبية 13
العاشر من رمضان 15
الغربية

What are they ?
Some cleaning need to be done !

thierry_gd’s picture

thierry_gd commented
Status: Active » Needs work
agharbeia’s picture

agharbeia commented

That's Arabic text encoded in UTF-8. Your editor probably didn't guess that.
It's a brief area codes' guide, the names are locales in Egypt. It's part of the comments explaining the RegEx.

agharbeia’s picture

agharbeia commented
Version: 6.x-2.9 » master
Status: Needs work » Needs review

changing status

thierry_gd’s picture

thierry_gd commented

Taken into account in 6.2.11 release

agharbeia’s picture

agharbeia commented
StatusFileSize
new phone.eg_.inc_.diff282 bytes

a fix in one RegEx instance: 4 digits instead of 3

thierry_gd’s picture

thierry_gd commented
Status: Needs review » Fixed

taken into account in 6.2.13 version

Status: Fixed » Closed (fixed)
Issue tags: -telephone, -egypt

Automatically closed -- issue fixed for 2 weeks with no activity.

Issue tags: +telephone, +egypt

Restoring issue tags, see #2125755: System messages removed all issue tags during D7 upgrade.