Code review doesn't display results table because of api changes in hook_theme, see #600974: theme() fails for theme functions taking one argument in renderable arrays

Thos are the messages i got:

    *  Notice: Undefined index: render element in theme() (line 803 of /home/sauditor/workspace/nowblogging/includes/theme.inc).
    * Notice: Undefined index: form in theme_coder_review_table_cols() (line 534 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Warning: Invalid argument supplied for foreach() in theme_coder_review_table_cols() (line 537 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Warning: Invalid argument supplied for foreach() in theme_coder_review_table_cols() (line 546 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: render element in theme() (line 803 of /home/sauditor/workspace/nowblogging/includes/theme.inc).
    * Notice: Undefined index: form in theme_coder_review_table_cols() (line 534 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Warning: Invalid argument supplied for foreach() in theme_coder_review_table_cols() (line 537 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Warning: Invalid argument supplied for foreach() in theme_coder_review_table_cols() (line 546 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: render element in theme() (line 803 of /home/sauditor/workspace/nowblogging/includes/theme.inc).
    * Notice: Undefined index: name in theme_coder_review() (line 1950 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: filename in theme_coder_review() (line 1951 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: results in theme_coder_review() (line 1952 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: render element in theme() (line 803 of /home/sauditor/workspace/nowblogging/includes/theme.inc).
    * Notice: Undefined index: name in theme_coder_review() (line 1950 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: filename in theme_coder_review() (line 1951 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: results in theme_coder_review() (line 1952 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: render element in theme() (line 803 of /home/sauditor/workspace/nowblogging/includes/theme.inc).
    * Notice: Undefined index: name in theme_coder_review() (line 1950 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: filename in theme_coder_review() (line 1951 of /home/sauditor/workspace/coder/coder_review/coder_review.module).
    * Notice: Undefined index: results in theme_coder_review() (line 1952 of /home/sauditor/workspace/coder/coder_review/coder_review.module).

Attached is a patch that fixes the issue.

CommentFileSizeAuthor
#8 coder-review-hook_theme-03.patch1.88 KBcedarm
#4 coder-review-hook_theme-02.patch1.24 KBilo
coder-review-hook_theme-01.patch1.51 KBsanduhrs

Comments

sanduhrs’s picture

sanduhrs
he/him
Primary language German
Location 🇪🇺 Heidelberg, Germany, Europe
commented

The Select specific modules and Select specific themes fieldsets aren't populated aswell.

deviantintegral’s picture

deviantintegral commented

This patch works for me at first blush - remember to clear your caches.

ilo’s picture

ilo commented

I also tested and no errors in theme.

ilo’s picture

ilo commented
StatusFileSize
new coder-review-hook_theme-02.patch1.24 KB

Actually, it fixes the errors from theme, but make form hidden for render function. This is an updated patch.

pwolanin’s picture

pwolanin commented

patch seems to work for me

JacobSingh’s picture

JacobSingh commented

Works for me to.

ilo’s picture

ilo commented

perhaps coder_upgrade should be included in this patch, it is not updated, and shows some warnings.

cedarm’s picture

cedarm commented
StatusFileSize
new coder-review-hook_theme-03.patch1.88 KB

I think these coder_upgrade warnings will only show up if you have no modules enabled which implement hook_upgrades(). $upgrades_sort just needs to be initialized to an empty array(). Tacked this onto the end of the patch.

solotandem’s picture

solotandem commented
Component: Code » Review/Rules
Assigned: solotandem » Unassigned
Status: Fixed » Needs review

Regarding #7 and #8, Coder upgrade has been fixed. The warnings related to the reversal of the registry changes which again requires manual inclusion of code files.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Component: Review/Rules » Code
dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Reviewed & tested by the community

Confirmed the patch makes coder review work with current D7 HEAD.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Side note, if any of the current maintainers would approve of me being added as a co-maintainer for these types of HEAD-chasing issues, I'd love to help be able to commit these types of changes. I'm already assisting with admin_menu and devel with this same work.

solotandem’s picture

solotandem commented
Assigned: Unassigned » solotandem
Status: Reviewed & tested by the community » Fixed

Fixed in the next dev release.

cedarm, thanks for the patch.

Component: Review/Rules » Code
Assigned: Unassigned » solotandem
Status: Needs review » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.