Download & Extend

permissions_revoke_permissions error

Project:Permissions API
Version:6.x-2.5
Component:Code
Category:bug report
Priority:critical
Assigned:ebeyrent
Status:closed (fixed)

Issue Summary

In the permissions_revoke_permissions function there is the following error:

<?php
foreach($new_permissions as $permission){
       
$index = array_search($permission, $permissions);       
        if(
$index >= FALSE){
        
/* The above question is a mistake because if the searched permission is not in the array you get FALSE that is converted to 0 so you revoke the
             first permission on the array.
             the code should be changed to if($index !== FALSE)
         */
         
unset($permissions[$index]);      
        }
      }
?>

I don't fix it my self because i dont know how to commit the change

Comments

#1

Assigned to:Anonymous» ebeyrent

I'll take a look at this right away; thanks for the bug report!

#2

This has been committed; I'll update the release soon.

#3

Status:active» fixed

Fixed in the 2.6 release

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.