When another form contains same ids, client stops working

alex_b - October 27, 2009 - 17:41
Project:Localization client
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

Situation: page contains a form with id="edit-target", hence "edit-target" in the translation form becomes "edit-target-1". JS in l10n client depends on "edit-target" and saving of new translations stops working.

Issue reported originally o OpenAtrium tracker https://community.openatrium.com/issues/node/685

Patch a-comin.

#1

alex_b - October 27, 2009 - 17:43
Assigned to:alex_b» Anonymous
Status:active» needs review

This patch uses classes instead of ids for selecting the target element and fixes the problem reported here https://community.openatrium.com/issues/node/685

AttachmentSize
616106-1_use_classes.patch 3.61 KB

#2

Gábor Hojtsy - October 28, 2009 - 14:27

Looks good. Did you notice any other similar places where IDs are used as selectors and can break while we are at it?

 
 

Drupal is a registered trademark of Dries Buytaert.