Download & Extend
OG Menu » Issues

debugging og_menu to work properly in Drupal 6

Posted by muschpusch on October 27, 2009 at 5:48pm
Project:OG Menu
Version:6.x-1.3
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed (won't fix)

Issue Summary

There are some bugs in this module. It would be better to change the status of og_menu to a lower level maybe beta until these things are fixed...

1.) it's only working with the content type "pages"
2.) the module shouldn't be triggered on non organic group posts
3.) the module shouldn't be triggered for admin
4.) #544446: Permissions allow access to all OG menus isn't fixed

I made a patch for 1,3 and 4 but i have no solution for 2.. I'm new to drupal development so help me out a little...!

AttachmentSize
og_menu.patch2.01 KB
Login or register to post comments

Comments

#1

Posted by jide on October 27, 2009 at 5:51pm

That's a really great initiative mushpusch, I hope maintainers will react to this.

#2

Posted by jide on October 27, 2009 at 5:52pm

I'll try to find some time to help with 2) if I can.

#3

Posted by jide on October 27, 2009 at 5:57pm

for 1), in the og_menu_form_alter() function, it may be better to do like this :

<?php
if ($form['#id'] == 'node-form' && $form['menu']) {
?>

#4

Posted by muschpusch on October 29, 2009 at 10:07am

Hey Jide, thanks for 1).... inspecting the $form module i also found a solution for 2.)

<?php
if ($form['#id'] == 'node-form' && $form['menu'] && is_array($form['og_invisible'])) {
?>

Do you know how to get CVS access to commit the changes? I'm getting the idea that this module is not maintained anymore....

AttachmentSize
og_menu.patch 2.06 KB

#5

Posted by jide on November 7, 2009 at 3:55pm

@muschpusch : see http://drupal.org/node/251466. I am with you if you want to become the maintainer of the project ! But I think It could need a more deep rewrite.

#6

Posted by jide on November 7, 2009 at 4:01pm

I wrote to the maintainer via his contact form, let's see if he answers.

#7

Posted by muschpusch on November 13, 2009 at 12:34pm

He Jide... i'm not sure if i really can be the maintainer of the project because i'm relative new to drupal... It's ok for me when you help & review the code. There are a lot of patches for the module and some offer better solutions than my modifications. Maybe we could start with a chat meeting?

#8

Posted by bricef on November 25, 2009 at 7:52pm

Nice work.

For 2 you can use the function og_get_types('group_post') to get all group_post content type. I had problems to apply your patch, can you follow the rules printed there : http://drupal.org/node/323 ?

#9

Posted by bricef on November 25, 2009 at 8:18pm

I just saw that this patch can help for 2 http://drupal.org/node/483948.

#10

Posted by jide on November 25, 2009 at 8:29pm

Thanks for helping bricef. I am now co-maintainer of this module (though i did not really want to) and I must find some time to make at least a release that *works*. For the moment, the module is awfully broken. I am not sure this patch resolves the biggest issues, maybe I'll go for a complete rewrite, but I have to review all pending patches before. Any help will be appreciated !

#11

Posted by jide on November 25, 2009 at 8:31pm

Maybe the first move will be to correct the biggest issues, publish it as an alpha version or something, and then when I got time, make a complete rewrite.

#12

Posted by bricef on November 25, 2009 at 8:42pm

I have to use this module on one of my website. I suggest to apply some patchs and test in order to correct some obvious bug. I can help if you want but i have no CVS account.

#13

Posted by jide on December 25, 2009 at 4:41pm
Status:needs work» needs review

Test the new 2.x branch.

#14

Posted by jide on July 20, 2010 at 4:07pm
Status:needs review» closed (won't fix)

Since the 2.x branch has been released, I close this issue. Feel free to reopen if the problem occurs again.