Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I ran into some trouble with dibs_load_settings, since I had not set any default dibs settings on my site, only for the specific implementation that I was working on, in which case the merging code in dibs_load_settings would return an empty array, causing a redirect loop. I fixed the redirect loop and then got to work at fixing the issue with dibs_load_settings.
I've refactored it, and it seems to be working as intended, but if you could look it over to check that I'm not breaking something for some weird use case.
Also, the order id settings are only being loaded if the default settings are not. Is that intentional? If so, I think there should be a comment about it in the code :)
| Comment | File | Size | Author |
|---|---|---|---|
| 2009-10-27-default-settings.patch | 1.94 KB | mikl |
Comments
Comment #1
beltofteI have just been looking fast at the patch and it looks fine actually :-) I will test it this week so be sure that it don't break anything.
About the order settings. I actually can't remember if it should be the idea, but it does not sound so smart ;-) You are welcome to fix it and commit the bug fix.
Comment #2
beltofte