Another one. No coder or test errors.
One issue: the UTF8 issue #209560: Filter example and SA-2008-006 marked as fixed may be wrong. Current HEAD branch is not fixed (find "\xFEtime /\xFF" text in the patch file).
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | examples.filter_d7_616474_08.patch | 5.19 KB | rfay |
| #4 | filter_example_d7_rfay_01.patch | 14.28 KB | rfay |
| #2 | filter_example_drupal_7_ilo_1.patch | 15.28 KB | ilo |
| filter_example_drupal_7_ilo.patch | 14.73 KB | ilo |
Comments
Comment #1
ilo commentedNevermind, aparently my cvs copy was not from the right place, but for documentation. I'll reroll it.
Comment #2
ilo commentedForget about the issue for the SA. The patch has been rerolled.
Comment #3
dave reidReminder: Please commit D7 patches to the HEAD CVS branch, not DRUPAL-7--1.
Comment #4
rfayI committed this (attached) with small changes, mostly cosmetic, including reformatting with spaces. http://drupal.org/cvs?commit=286588
Now let's fix up the commenting of the
<time />filter so it has filter tips and decent commenting. Right now it's not even possible for a programmer to understand what to use to test it.Comment #5
bdragon commentedYoink!
Comment #6
bdragon commentedUnassigning, it's a lot further than I thought it was, it's just that api.drupal.org isn't pulling the examples project yet.
Running off to bang on THAT for a while.
Comment #7
rfayYour help is much appreciated in both places.
#619442: Use examples from Examples for Developers project on api.drupal.org is the issue about api.d.o processing.
A current api version is at
http://api.dev.randyfay.com/
Comment #8
rfayThis patch adds a little information menu and page to the example, and adds filter tips to the
<time />filter. I think it will be a bit more comprehensible now.In general, we need the clicking user to be able to find and use the example without looking at the code. Then when they understand it they can go to the code.
Comment #9
rfayCommitted: http://drupal.org/cvs?commit=326688
Thanks for all the fine work everybody!
Followup in #709376: Don't use invalid UTF characters for the example time filter though.