Another one. No coder or test errors.

One issue: the UTF8 issue #209560: Filter example and SA-2008-006 marked as fixed may be wrong. Current HEAD branch is not fixed (find "\xFEtime /\xFF" text in the patch file).

Comments

ilo’s picture

Status: Needs review » Needs work

Nevermind, aparently my cvs copy was not from the right place, but for documentation. I'll reroll it.

ilo’s picture

Status: Needs work » Needs review
StatusFileSize
new15.28 KB

Forget about the issue for the SA. The patch has been rerolled.

dave reid’s picture

Reminder: Please commit D7 patches to the HEAD CVS branch, not DRUPAL-7--1.

rfay’s picture

Status: Needs review » Needs work
StatusFileSize
new14.28 KB

I committed this (attached) with small changes, mostly cosmetic, including reformatting with spaces. http://drupal.org/cvs?commit=286588

Now let's fix up the commenting of the <time /> filter so it has filter tips and decent commenting. Right now it's not even possible for a programmer to understand what to use to test it.

bdragon’s picture

Assigned: Unassigned » bdragon

Yoink!

bdragon’s picture

Assigned: bdragon » Unassigned

Unassigning, it's a lot further than I thought it was, it's just that api.drupal.org isn't pulling the examples project yet.
Running off to bang on THAT for a while.

rfay’s picture

Your help is much appreciated in both places.

#619442: Use examples from Examples for Developers project on api.drupal.org is the issue about api.d.o processing.

A current api version is at
http://api.dev.randyfay.com/

rfay’s picture

Status: Needs work » Needs review
StatusFileSize
new5.19 KB

This patch adds a little information menu and page to the example, and adds filter tips to the <time /> filter. I think it will be a bit more comprehensible now.

In general, we need the clicking user to be able to find and use the example without looking at the code. Then when they understand it they can go to the code.

rfay’s picture

Status: Needs review » Fixed

Committed: http://drupal.org/cvs?commit=326688

Thanks for all the fine work everybody!

Followup in #709376: Don't use invalid UTF characters for the example time filter though.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.