Closed (fixed)
Project:
Project Issue File Review
Version:
6.x-2.x-dev
Component:
Documentation
Priority:
Normal
Category:
Support request
Assigned:
Reporter:
Created:
28 Oct 2009 at 03:05 UTC
Updated:
20 Feb 2010 at 07:18 UTC
Jump to comment: Most recent file
Comments
Comment #1
boombatower commentedIt was expecting an a failing test, but instead it got a php syntax error. Thus something went wrong. Is the patch out of date? I believer I had to update it recently, make sure the patches in the files directory/pifr_simpletest are the same as pifr/review/simpletest/confirmation.
Comment #2
deekayen commentedNo difference between the fail.patch files or the rest of them for that matter:
Though there is one extra patch.patch file in the files directory, the contents of which are
vs
I see you just made some commits, so I'll do a completely fresh install and try again.
Comment #3
deekayen commentedI'm using a fresh install now. It also happens occasionally during step 7 of the self test for the install.patch file. Same situation as aforementioned step 9, "Invalid PHP syntax in install.php."
Comment #4
boombatower commentedHmm...something we need to look into more I guess. I have never gotten PHP syntax errors when performing self tests like this.
Comment #5
deekayen commentedUnfortunately I have had this problem before and changing to a different linux distro fixed it. I could start trying that again, but it gets old bouncing from distro to distro without knowing what the root cause is...
In this case, it is Ubuntu 9.04 i386, which has been the most dependable one for me to sandbox with in the past. PIFR 1 client #44 is on Debian 5.0... I guess I could try that next.
Comment #6
boombatower commentedThe checkout code should be left after review. Can you look at the offending file and see if there is a syntax error? If so then perhaps something weird with
patchutil?Comment #7
deekayen commentedI checked /var/log/apache2/error.log and discovered this after each failed self test:
This is really the entire
cvs diff -uwhen it breaks on #7 for "Invalid PHP syntax in install.php."Is there a php.ini setting that would cause a missing function to be interpreted as invalid PHP syntax? I checked against a stock php.ini-recommended file and changed a few things that Ubuntu's version differed from, but that didn't fix this problem. Maybe a module I shouldn't have installed in mod_php?
Comment #8
deekayen commentedSo... whatever it is about Linode's Ubuntu 9.04 i386 image causes segfaults that don't happen in their Debian 5.0 i386 image, because I got past all that by starting over in Debian 5.0.
Comment #9
deekayen commentedI resolved this problem by doing one of the following:
a2enmod deflate
/etc/init.d/apache2 restart
If not that, then try, in /etc/apache2/conf.d/security
ServerTokens Minimal
ServerSignature Off
TraceEnable Off
Make sure your /etc/php5/apache2/php.ini and /etc/php5/cli/php.ini
files have
display_errors = On
log_errors = Off
In /etc/apache2/apache2.conf and /etc/apache2/sites-available/default
comment out or remove the custom log.
In /etc/apache2/sites-available/default, remove the docs and cgi-bin
directory options.
I think deflate is the actual fix, but I did all those things at the same time, so I'm not entirely sure which one did it. I'm running a test with #48 right now with deflate module disabled to make sure.
Comment #10
deekayen commentedIt's not deflate or security that fixes it. Still trying stuff. Right now I'm trying CustomLog in apache2.conf.
Comment #11
deekayen commentedI reverted all the stuff in #9 to back what it was when it was broken and I can't break it again so I can confirm what the fix was. Either I did something I have forgotten about doing or the mere act of restarting apache2 fixed it. When I can get my hands on another broken install, I'll diff the /etc/php5 and /etc/apache2 directories with a working server. I know those are the only two places I touched any files when I was working on debugging this.
Comment #12
Ryan Palmer commentedMod_deflate was enabled for my last few builds of my linode testing slave. I tried the other suggestions as well (definitely restarted apache, too), with similar failures.
I can post tarballs of apache and php conf but I think it will be more effective to just hand the broken linode to deekayen. Will follow up directly.
Comment #13
deekayen commentedI diffed Ryan's linode with mine, so they should be using the same base VM image. The PHP configuration looks alright. The only difference I found was the memory, which is more related to #534484: increase recommended php memory_limit to 384M.
Apache differs only slightly. I don't see anything to act on, yet. They differ in i686 vs x86_64, but Damien's working client is x86_64 on Lenny, so that's probably not the cause either.
Comment #14
deekayen commentedNow I'm really confused. Both machines are running at linode, they have the same OS, the same diff and patch versions, and the attached diff of /var/www shows only the fail.patch, settings.php connection information, and cvs vs package versions in the d6 core checkout.
Comment #15
deekayen commentedMaybe I'm still missing something in this diff that is consequential, but I still don't see anything in the /etc diff between Ryan and Damien's servers that would cause this failure.
Comment #16
deekayen commentedHow about this diff of package installs from Ryan's to my server or Ryan's to Damien's? Is there something else installed that could make the difference? I put php5-mcrypt and php5-mhash on Ryan's machine and that didn't fix it.
Comment #17
boombatower commentedAny updates on this? Mark as closed?
Comment #18
deekayen commentedI don't think it's closed. I think Ryan and others just gave up trying to figure it out.
Comment #19
boombatower commentedhmm, that's not good.
Comment #20
Ryan Palmer commentedMore or less. The new testing slave spec requirements are deferring my involvement for now, but I'll reevaluate again next year.
Comment #21
boombatower commentedCan we close this or is this still something that needs to be worked out?
Comment #22
deekayen commentedi haven't seen this happen in a while