This is an update to my previous patch (#605980) that has the following improvements for JSON output:

1. An improved method for placing commas between fields that takes into account empty fields that get skipped over.
2. Views UI previewing wraps the JSON preview within a tag and also formats HTML values to be displayed as regular text.
3. A much-improved views_json_get_json() function that is leaner and hopefully bug-free.

P.S. What is the right way to make a clean patch ?

CommentFileSizeAuthor
views_datasource_alpha3_003.patch112.47 KBicylace

Comments

icylace’s picture

icylace commented

Whoops, the referenced issue link is #605980: new functionality for the JSON stuff + more formatting improvements + more code changes (I forgot to type in the brackets) and the "code" tag in #2 wasn't supposed to get interpreted. I should really proof-read my posts :)

allisterbeharry’s picture

allisterbeharry commented
Assigned: Unassigned » allisterbeharry
Status: Needs review » Fixed

Thanks so much for your work and sorry for the delay. Committed to the DRUPAL-6--1 branch. Instructions for creating a patch against CVS are here: http://drupal.org/patch/create. Your patch was ok except for it being relative to a vd0 directory. But graphical IDEs can be instructed to ignore the directories in the patch.

icylace’s picture

icylace commented

Thank you for making such a wonderful module! I rely on it heavily and I've been continuing my development for it. Soon I'll be submitting a patch that adds support for encoding nested objects and arrays and some other stuff. I'll do my best to make cleaner patches from now on.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.