Hi,

I've patched FPSS to make overwriting the existing css optional. I found that I had to continually reupload my customized css after making non-css changes to the slideshow. That is something I don't want my clients to have to deal with.

If you are interested in a patch toward a commit (and I hope you are) please let me know and I'll provide the patch immediately.

Thanks,

Aaron

CommentFileSizeAuthor
#4 fpss.patch13.16 KBawolfey

Comments

joecanti’s picture

joecanti commented

I think that would be a good addition. You can also add the css changes to your theme css - better for upgrades, but I guess if you have to make a lot of changes it could add unnecessary weight to your theme css.

Joe

joecanti’s picture

joecanti commented

Well I thought you could add css additions to the theme css - turns out you can only do it for some things which is strange? anyway... yes, thumbs up for a patch!

cheers, joe

joecanti’s picture

joecanti commented

Awolfey, do you think you could let me know how you turned the css auto generation off please? I dont need mine to be switchable - although switchable would be the best method I guess...

cheers, joe

awolfey’s picture

awolfey commented
StatusFileSize
new fpss.patch13.16 KB

Joe, this patch does what you ask and more:

It's against 6.x beta2

1. specify if css is overwritten.
2. add weight to slides for ordering of show
3. adds permission "edit any slide"
4. fixes the click to navigate (previously did nothing)
5. Hard codes Slide title and Slide Text labels on form.

So, pick through it for what you need. I'm not going to be able to support you on this. Maybe the maintainer will take interest.

Good luck!

Aaron

joecanti’s picture

joecanti commented

Hi Aaron,

Thanks for the patch...but unfortunately it didnt work out for me. The weight wasn't being 'stored' anywhere...

If you're interested here is the error:

user warning: Unknown column 'weight' in 'field list' query: INSERT INTO fpss_slides (nid, vid, ssid, weight, slide_url, slide_cat, slide_tag) VALUES (191, 191, 185, 2, 'http://www.tri4africa.co.uk/blog', 'blog2', 'this is the blog') in /var/www/users/rforbes/tri4africa.co.uk/sites/all/modules/fpss/fpss.module on line 752.

Thanks for trying though, and I definately think its worth persuing for this module but i understand your time contraints...

Any one else interested in seeing this patch a commit?? Maintaner??
Many thanks, joe

awolfey’s picture

awolfey commented

Yes, sorry. I forgot to explain that you'll either have to uninstall and reinstall the module, or you can look in the .install file and apply the changes to the db manually.

It's just a patch, so I did not create an update function.

If the maintainer shows any interest I'll work on it further.

Aaron

joecanti’s picture

joecanti commented

Hi Aaron,

Im installing it on another site of mine - will try the patch and report back here...

cheers, joe

joecanti’s picture

joecanti commented

Hi Aaron,
Have just unistalled and re installed the patch (removing db references) and everything is working great so thankyou very much. The slide weighting is an excellent feature, and the ability to turn the css overwriting off works well...

I think that this patch should be incorporated into the module.

I would suggest that if it became part of the module one extra change would be implemented to avoid confusion - the css should be split into 2 bits: one to deal with everything you enter into the module settings eg width and height. This one would be overwritten every time a change was made, and there would be no need to manualy edit. And the second part of the css which never gets overwritten, which deals with everything not adjustable in the module settings.

This would enable beginners to edit basic stuff like width/height, and advanced users to change everything else.

For now though, everything works great - good job Aaron and thanks for sharing that :-)

cheers, joe