I've rewritten parts of the installer script to add PostgreSQL support.
Unfortunately this led to some complications, as PostgreSQL requires db_next_id()'s $name parameter to be in a certain format, namely: {table}_pkfield, in which they weren't. Solving this issue requires two things:

  • a patch for workflow.module that corrects the bad namings, and
  • an update hook for MySQL users to change the existing sequence names accordingly.

This post has the new installer script attached, making workflow.pgsql superfluous. The next one will contain the patch for workflow.module.

MySQL users must run the updater located at http://www.example.com/update.php after replacing workflow.install.

CommentFileSizeAuthor
#13 workflow_5.patch1.19 KBsmk-ka
#11 workflow.install_pgsql.patch351 bytespearcec@drupal.org
#5 workflow_2.patch15.37 KBsmk-ka
#2 workflow.diff2.49 KBsmk-ka
#1 nextid_fix.diff1.39 KBsmk-ka
workflow_1.install8.88 KBsmk-ka

Comments

smk-ka’s picture

smk-ka commented
StatusFileSize
new nextid_fix.diff1.39 KB

Note: rename workflow_1.install to workflow.install

The patch for workflow.module.

smk-ka’s picture

smk-ka commented
StatusFileSize
new workflow.diff2.49 KB

Found another bug, so forget nextid_fix.diff: Postgres doesn't understand && in a query, so you have to use AND.

sammys’s picture

sammys commented

It doesn't appear this has received any priority for inclusion into the module. I bump this up again so we can deal with it. smk-ka: Please supply the necessary changes to workflow.module and workflow.install in one single patch? I'll review the patch so we can get this included.

--
Sammy Spets
Synerger
http://www.synerger.com

sammys’s picture

sammys commented
Status: Needs review » Needs work

I'm tying this issue along with http://drupal.org/node/31743 as there is a bug in the cvs version of the module preventing me from manipulating/creating transitions. I'm also bumping the status of this issue to patch (code needs work).

Cheers,

--
Sammy Spets
Synerger
http://www.synerger.com

smk-ka’s picture

smk-ka commented
Title: PostgreSQL support » PostgreSQL support with required code changes
Status: Needs work » Needs review
StatusFileSize
new workflow_2.patch15.37 KB

Thanks for taking the time, Sammy. Here you go:

  • Synced with cvs (13/06/2006 - 22:31).
  • New all-in-one patch includes all necessary code changes.
jvandyk’s picture

jvandyk commented

I'd appreciate it if someone could test this, please.

sammys’s picture

sammys commented
Status: Needs review » Reviewed & tested by the community

Patch worked for me. It's good to go from my perspective.

jvandyk’s picture

jvandyk commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)
jvandyk’s picture

jvandyk commented
Version: » 6.x-1.x-dev

Note: this patch was incorrect because update_sql does not support %s syntax. You must build the SQL string yourself if you're going to pass it to update_sql.

pearcec@drupal.org’s picture

pearcec@drupal.org commented
Version: 6.x-1.x-dev » 5.x-1.1
Status: Closed (fixed) » Reviewed & tested by the community
StatusFileSize
new workflow.install_pgsql.patch351 bytes

When this file was updated during version 1.7 it didn't get the stamp field on workflow_node. I am adding a patch to fix it.

Tabbycat’s picture

Tabbycat commented

workflow_access.install has "unsigned" in the column definitions for grant_view, grant_update and grant_delete for the "pgsql" case so it errors for postgres - just needs "unsigned" removing from those lines.

smk-ka’s picture

smk-ka commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new workflow_5.patch1.19 KB

New patch includes #11 and fixes #12.

Bastlynn’s picture

Bastlynn commented
Status: Needs review » Closed (won't fix)

Hi,

With the release of Drupal 7, Drupal 5 is no longer receiving security updates, reviews, or development from many contributed modules. Since 5 is now considered a depreciated version, you really should seriously look into upgrading to Drupal 6 or 7. The newer versions of Drupal work better, have more support, and will be safer (literally! security patches!) for your website. We are currently working on a new release for Workflow to Drupal 7. In light of that, further support for Drupal 5 issues is infeasible at the moment. Please consider upgrading to Drupal 6 or 7 in the near future - you'll be glad you did.

- Bastlynn