Doesn't record subscription when only one subscription type is enabled (and lots more tests)

axel_exa - October 28, 2009 - 16:03
Project:Comment Notify
Version:5.x-2.x-dev
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:patch (to be ported)
Description

The following problem still occures with me (6.x.1.x-dev from Oct 21):

http://drupal.org/node/430428

Interestingly, subscriptions get recorded if I edit a comment afterwards:

I create a comment (as Admin or Anonymous) and select the subscribe checkbox.
I edit the comment - the subscription is disabled.
I select the checkbox again and save.
I edit the commen again - this time the subscription is there.

I also tried the ver1.2, but there it never records a subscription, even if I edit the comment.

Any ideas? Thanks.

#1

greggles - November 6, 2009 - 23:19
Priority:normal» critical
Assigned to:Anonymous» greggles
Status:active» needs review

Absolutely right! What a bummer. Can you test this patch?

AttachmentSize
617070_comment_notify_actually_save_notify_type.patch 1.72 KB

#2

greggles - November 7, 2009 - 00:52

Here's another version with a simpletest to catch the error and some more general cleanup.

AttachmentSize
617070_comment_notify_actually_save_notify_type_2.patch 12.4 KB

#3

greggles - November 7, 2009 - 18:40
Title:Still doesn't record subscription when only one subscription type is enabled» Doesn't record subscription when only one subscription type is enabled (and lots more tests)
Assigned to:greggles» Anonymous
Status:needs review» patch (to be ported)

Now committed - http://drupal.org/cvs?commit=285524

Let me know if you still have problems with this.

#4

greggles - November 17, 2009 - 18:20
Version:7.x-1.x-dev» 5.x-2.x-dev
 
 

Drupal is a registered trademark of Dries Buytaert.