The following problem still occures with me (6.x.1.x-dev from Oct 21):

http://drupal.org/node/430428

Interestingly, subscriptions get recorded if I edit a comment afterwards:

I create a comment (as Admin or Anonymous) and select the subscribe checkbox.
I edit the comment - the subscription is disabled.
I select the checkbox again and save.
I edit the commen again - this time the subscription is there.

I also tried the ver1.2, but there it never records a subscription, even if I edit the comment.

Any ideas? Thanks.

CommentFileSizeAuthor
#2 617070_comment_notify_actually_save_notify_type_2.patch12.4 KBgreggles
#1 617070_comment_notify_actually_save_notify_type.patch1.72 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Assigned: Unassigned » greggles
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new 617070_comment_notify_actually_save_notify_type.patch1.72 KB

Absolutely right! What a bummer. Can you test this patch?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
StatusFileSize
new 617070_comment_notify_actually_save_notify_type_2.patch12.4 KB

Here's another version with a simpletest to catch the error and some more general cleanup.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Title: Still doesn't record subscription when only one subscription type is enabled » Doesn't record subscription when only one subscription type is enabled (and lots more tests)
Assigned: greggles » Unassigned
Status: Needs review » Patch (to be ported)

Now committed - http://drupal.org/cvs?commit=285524

Let me know if you still have problems with this.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Version: 7.x-1.x-dev » 5.x-2.x-dev
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Patch (to be ported) » Closed (fixed)

This module is no longer actively developed for Drupal 5. If someone wishes to take over as the 5.x maintainer I would consider it, but these days everyone should really upgrade to Drupal 6.x.