Problem with Storm Invoices Nodes After Upgrade to 6.x-1.25

WebNewCastle - October 29, 2009 - 02:22
Project:Storm
Version:6.x-1.25
Component:Storm Invoice
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I just wanted to mention that current Storm Invoices get deleted when upgrading to version 6.x-1.25 (after running update script).

#1

WebNewCastle - October 29, 2009 - 02:29
Title:Storm Invoices Get Deleted on Upgrade to 6.x-1.25» Problem with Storm Invoices Nodes After Upgrade to 6.x-1.25

#2

WebNewCastle - October 29, 2009 - 02:34

Clarification: It's the Invoice Items that were deleted (not the Invoices) - and I apologize I didn't see the corresponding line in the queries for this before posting. But what I found is that I can't display Invoice Nodes after the upgrade (although I can get to the Edit page). I'm seeing this when I try to display an Invoice node:

Fatal error: Cannot use object of type stdClass as array in .... /includes/theme.inc on line 1339

This isn't an issue for me per se because this is old content that I don't need, but I just thought I would mention what I found.

#3

Magnity - October 29, 2009 - 05:38
Priority:normal» critical

The deletion of Invoice items is by design and is part of the solution to the access bypass issue.

The fatal error when viewing invoices is not (!) - needs sorting out if this is happening with everyone's install.

If anyone else finds this - please post. Assuming it is a widespread bug i'll try to get a fix and new release out asap.

#4

Magnity - October 29, 2009 - 17:43
Status:active» fixed

I've found and hopefully fixed the problem.

Just about to commit to -dev and create new release.

AttachmentSize
storminvoice.theme_.inc_.patch 1.5 KB

#5

WebNewCastle - October 31, 2009 - 03:28

Hi Magnity,

Yes, sorry about the initial post. I didn't pay close enough attention to the details after running the upgrade script.

- Matt

#6

recrit - November 5, 2009 - 18:29
Status:fixed» needs review

I was going to create a new ticket but the issue stems from this patch...
This patch changes the database fetching to db_fetch_array from db_fetch_object on line 331 of the latest 6.x-1.x-dev 2009-Oct-30. However the following foreach formatting loop to build the $invoice_items still treats $inv_item as an object. This causes all the items amounts, taxes, and totals to be 0.

Fix: change formatting loop variable access to $inv_item['amount'] ...

#7

Magnity - November 6, 2009 - 00:34
Status:needs review» fixed

Thanks. Fixed by patch below and in latest -dev when it next rolls.

AttachmentSize
storminvoice.theme_.inc_.patch 1.17 KB

#8

System Message - November 20, 2009 - 00:40
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.