I just wanted to mention that current Storm Invoices get deleted when upgrading to version 6.x-1.25 (after running update script).

CommentFileSizeAuthor
#7 storminvoice.theme_.inc_.patch1.17 KBMagnity
#4 storminvoice.theme_.inc_.patch1.5 KBMagnity

Comments

WebNewCastle’s picture

WebNewCastle commented
Title: Storm Invoices Get Deleted on Upgrade to 6.x-1.25 » Problem with Storm Invoices Nodes After Upgrade to 6.x-1.25
WebNewCastle’s picture

WebNewCastle commented

Clarification: It's the Invoice Items that were deleted (not the Invoices) - and I apologize I didn't see the corresponding line in the queries for this before posting. But what I found is that I can't display Invoice Nodes after the upgrade (although I can get to the Edit page). I'm seeing this when I try to display an Invoice node:

Fatal error: Cannot use object of type stdClass as array in .... /includes/theme.inc on line 1339

This isn't an issue for me per se because this is old content that I don't need, but I just thought I would mention what I found.

Magnity’s picture

Magnity commented
Priority: Normal » Critical

The deletion of Invoice items is by design and is part of the solution to the access bypass issue.

The fatal error when viewing invoices is not (!) - needs sorting out if this is happening with everyone's install.

If anyone else finds this - please post. Assuming it is a widespread bug i'll try to get a fix and new release out asap.

Magnity’s picture

Magnity commented
Status: Active » Fixed
StatusFileSize
new storminvoice.theme_.inc_.patch1.5 KB

I've found and hopefully fixed the problem.

Just about to commit to -dev and create new release.

WebNewCastle’s picture

WebNewCastle commented

Hi Magnity,

Yes, sorry about the initial post. I didn't pay close enough attention to the details after running the upgrade script.

- Matt

recrit’s picture

recrit commented
Status: Fixed » Needs review

I was going to create a new ticket but the issue stems from this patch...
This patch changes the database fetching to db_fetch_array from db_fetch_object on line 331 of the latest 6.x-1.x-dev 2009-Oct-30. However the following foreach formatting loop to build the $invoice_items still treats $inv_item as an object. This causes all the items amounts, taxes, and totals to be 0.

Fix: change formatting loop variable access to $inv_item['amount'] ...

Magnity’s picture

Magnity commented
Status: Needs review » Fixed
StatusFileSize
new storminvoice.theme_.inc_.patch1.17 KB

Thanks. Fixed by patch below and in latest -dev when it next rolls.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.