Posted by WebNewCastle on October 29, 2009 at 2:22am
| Project: | Storm |
| Version: | 6.x-1.25 |
| Component: | Storm Invoice |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
I just wanted to mention that current Storm Invoices get deleted when upgrading to version 6.x-1.25 (after running update script).
Comments
#1
#2
Clarification: It's the Invoice Items that were deleted (not the Invoices) - and I apologize I didn't see the corresponding line in the queries for this before posting. But what I found is that I can't display Invoice Nodes after the upgrade (although I can get to the Edit page). I'm seeing this when I try to display an Invoice node:
Fatal error: Cannot use object of type stdClass as array in .... /includes/theme.inc on line 1339
This isn't an issue for me per se because this is old content that I don't need, but I just thought I would mention what I found.
#3
The deletion of Invoice items is by design and is part of the solution to the access bypass issue.
The fatal error when viewing invoices is not (!) - needs sorting out if this is happening with everyone's install.
If anyone else finds this - please post. Assuming it is a widespread bug i'll try to get a fix and new release out asap.
#4
I've found and hopefully fixed the problem.
Just about to commit to -dev and create new release.
#5
Hi Magnity,
Yes, sorry about the initial post. I didn't pay close enough attention to the details after running the upgrade script.
- Matt
#6
I was going to create a new ticket but the issue stems from this patch...
This patch changes the database fetching to
db_fetch_arrayfromdb_fetch_objecton line 331 of the latest 6.x-1.x-dev 2009-Oct-30. However the following foreach formatting loop to build the$invoice_itemsstill treats$inv_itemas an object. This causes all the items amounts, taxes, and totals to be 0.Fix: change formatting loop variable access to
$inv_item['amount']...#7
Thanks. Fixed by patch below and in latest -dev when it next rolls.
#8
Automatically closed -- issue fixed for 2 weeks with no activity.