Posted by hass on October 29, 2009 at 10:45am
Jump to:
| Project: | Taxonomy menu |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Patch attached fixes many bugs, typos, missing t() and tons of other issues.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| taxonomy_menu_translatable_review-D6.patch | 18.73 KB | Ignored: Check issue status. | None | None |
Comments
#1
Marked #287920: German translation - translation refreshed as postponed until this patch has been committed.
#2
Looks mostly harmless. Can I get one more person to review so it can go to RBTC and I can commit it.
#3
Looks ok to me.
I applied the patch and noticed no ill effects.
#4
This is part of 6.x-2.4-beta2 release.
#5
Great. Could someone write a description for "Display descendants", please? It's currently "TODO"...
#6
I think we need to go another round with the strings. I mostly fixed code style issues with the above patch and a context sensitive string bugs, but most strings really need a re-wording. I'm not happy with many sentences as they are not very self explaining and have strange wordings. I'm not a native English speaker, but it sounds not good to me. Would be great if someone would try to make the sentences better...
#7
hass:
Lets just close this issue out.
Open a new issue(s) for more translation and UI work.
And please be specific if you can about where things need to be re-worded.
#8
Hass, I agree with you. I don't want you to spend to much time on this as I am close to a V3 release. The i18 work will be transferable but the strings will all be rewritten.
#9
That's fine, let's focus on 3.x for the rewordings. Have you taken over the latest changes here to 3.x?
#10
Automatically closed -- issue fixed for 2 weeks with no activity.