All forum containers visible to user if at node/add/forum?gids[]

james.williams - October 29, 2009 - 15:39
Project:OG Forum
Version:6.x-2.0
Component:Code
Category:bug report
Priority:normal
Assigned:paulbooker
Status:closed
Description

On the add forum topic page, if the gids argument is supplied as 'gids[]', all forum containers are visible in the 'Forums' drop down box, regardless of whether the logged in user actually has access to see them.

The attached patch checks to see if the user is a member of the supplied group. So if 'gids[]' is the argument, no query is returned for the list of forums, since the empty string is not a valid group id.

See the patch. This is the first one I've made so let me know if I've not explained it very well here!

AttachmentSize
og_forum-term-access.patch1.54 KB

#1

Steven Jones - October 29, 2009 - 15:40

subscribing.

#2

paulbooker - November 10, 2009 - 13:10

Great catch, ill get that committed today.

Best,
Paul Booker

#3

paulbooker - November 10, 2009 - 13:10
Status:needs review» closed

#4

paulbooker - November 10, 2009 - 13:11
Assigned to:Anonymous» paulbooker
Status:closed» fixed

Oops!

#5

System Message - November 24, 2009 - 13:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.