Project:Activity Stream
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

Hey there,

great module, hope it'll soon be able to replace sweetcron, so thanks at first.

Unfortunately I'm experiencing a little problem. All pages that display activitystream output (profile pages, '/stream/' and '/stream/{uid}' show up with the following warning, always 8 times the same message:

warning: Parameter 1 to theme_activitystream_header() expected to be a reference, value given in D:\xampp\htdocs_wentsch\includes\theme.inc on line 617.

Same issue on different versions, I tried 6.x-1.0-rc2 as well as 6.x-2.x-dev.
Switching themes didn't have an effect, neither (tried Garland, Framework, Five, Ninesixty and BlueTrip)

I'm running Drupal 6.14 on Windows 7 RC with XAMPP 1.7.2 and PHP 5.3.

I almost forgot to mention: the aggregation itself does work, the infos of twitter, flickr and delicious do get pulled into Drupal.

Regards,
Daniel

AttachmentSize
activitystream-error.gif67.12 KB

Comments

#1

It's likely that changing the line in activitystream.module from

function theme_activitystream_header(&$action) {

to

function theme_activitystream_header($action) {

(Remove the & from the line)

Would fix this. PHP5.3 changed how functions and references work in a way that causes issues with how Drupal's theme functions and hooks are implemented.

The other option would be to step back to PHP 5.2.

#2

Thanks a bunch, that helped :)

#3

Status:active» fixed

Fixed in CVS

#4

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#5

Can this fix released in a new package? It's kinda frustating to manual patching on every server with PHP 5.3

#6

Drupal builds the dev packages from CVS. So any time a change is committed to CVS on a project, it will be in the dev builds within 24 hours.

This fix is in the 2.x dev build now. Feel free to use that.

nobody click here