when a thread exists and a new reply is posted, when you click on the thread (as the receiving party) the whole thread doesn't come up, just the reply. if you then go back to the message list and click on the thread again, the whole thread will come up. i don't know if this is a bug or if it is a feature. is there a way to make it just show the whole thread every time you click on a thread? the thread lacks context when you can't see the whole thing.
thanks.
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | blueddo.zip | 74.45 KB | jaron |
| #12 | new_bug_test.patch | 1.88 KB | berdir |
| #5 | Picture 2.png | 33.43 KB | jaron |
| #5 | Picture 4.png | 42.62 KB | jaron |
Comments
Comment #1
berdirThat is supposed to be a feature. It should still display the full thread, the browser just jumps to the first unread message you should be able to scroll back.
If that's not the case, then it is a bug. But I'm pretty sure it does work correclty...
Comment #2
jaron commentedin firefox and safari, it only shows the reply. in fact, the reply isn't even housed in the normal layout for privatemsg. it is only the latest reply and then the reply-form.
i do like the idea of the browser jumping to the reply though. that would be a feature if the whole thread still existed.
Comment #3
berdirI am unable to reproduce that on my system. Please provide more information. I know that you are using several sub-modules, is there anything special about these broken threads? Are they maybe forwarded or something like that?
- Add some screenshots
- Post the links
- Check the mids (second id is mid, first is thread id) when the thread is broken and when it does work correctly. is thread_id the same?
- Sometimes, it helps to enable E_NOTICE messages (go to includes/common.inc, search for E_NOTICE and remove the "^ E_NOTICE" part from the check there. However, if you use many other modules, it might show a lot of errors now. But privatemsg.module should not throw any of those.
Comment #4
berdirRecategorizing as bug report.
Comment #5
jaron commentedok. a bit more information...
i tried this again with the latest -dev. i also did not put in any other sub-modules, nor did i patch the newest -dev. (the latest forwarding sub-mod requiring the patch.) so this is just based on the straight -dev from 10.30.09
it turns out this is not a reply issue but just a new posting issue. it happens even when a new thread is started. obviously when a thread is new, there is only the one posting, but the privatemsg layout doesn't show up in that scenario. i'm including two photos - one of the issue, the other of what the whole thread looks like. these are from a new thread, not one with replies, but the issue is the same - it only shows the latest post independent of the privatemsg layout (by that i mean the tabs and such).
i've also found that there is a difference in the address being supplied to the browser. when a thread or reply is new, it appends "#new" at the end of the address. i don't know if this is what you are referring to with the mid's and thread id. if not, please let me know how to find those id's. the number before the appended "#new" is the same for both the first time the thread is clicked (and doesn't show the private message layout) and the second time (showing the layout and the rest of the thread).
currently this is on my local server so i don't have any links for you, but i can upload the site if need be.
after removing the "^ E_NOTICE" i get the following notice (but it is shown for both scenarios)
notice: Undefined index: file in /Applications/MAMP/htdocs/10_27ddoMirror/includes/common.inc on line 2228.
the pictures are attached. let me know what else i can do to help troubleshoot.
Comment #6
berdirYes. The thing is, "#new" is not even sent to the server it is just used by the browser to jump to that location where
<a id="new" />is defined.Check the sent html if the other messages of a thread are really not there. Maybe it's just a theming issue.
Comment #7
jaron commentedhi berdir,
so you are on to it. in the html page source of the delivered page (one in which the thread is truncated) all of the messages are there, but only the last post is showing in the browser window.
do you have any idea what could be causing that? or how i would troubleshoot it? is it purely in the theme or is it how the theme interacts with privatemsg?
thanks.
Comment #8
berdirOk, then this probably isn't a bug in privatemsg.module then so let's change it back to a support request.
Are you overriding any privatemsg templates?
You can try to validate the page when it's broken. Save it as HTML and upload it to a site like http://validator.w3.org. There are also Firefox plugins that allow to do that in a single click. (Web Developer Toolbar)
Depending on your theme and customizations, there might be a lot of errors. Look out especially for things like tags that aren't closed since they might hide something they shouldn't.
Comment #9
jaron commentedi'm not aware of overriding any templates. definitely not privatemsg templates.
i tried the validator and got 5 errors in meta tags, but they are the same 5 errors that come up with the stock garland theme (in which the functionality in privatemsg works fine). they seem to have more to do with it running locally than with any actual content in the page.
any other thoughts or suggestions?
thanks.
Comment #10
berdirCan you upload the html page of a "broken" thread view so that I can have a look at it myself?
Also, does the same bug happen with other themes too?
Comment #11
jaron commentedhere you go:
http://www.jaronpresant.com/33.htm
it doesn't happen with garland. that's the only other theme i have in.
what is actually happening with the #new function? i can't see anything in the html that would suggest the break.
Comment #12
berdirThe HTML looks fine, so it seems that either a CSS definition or some JS code is doing something weird.
The only purpose of #new is that it tells the browser to jump to the point where a link with that name is defined.
It's quite hard for me to debug that without knowing what the theme is doing, but the attached patch renames #new to #privatemsg-new to avoid naming conflicts. Try it with that again.
If that doesn't help, I can't help you anymore since it's obvious that your theme is provoking the bug and that it does work fine with Garland and you will have to debug it yourself.
Comment #13
jaron commentedthe patch actually makes the browser skip all of the posts in the thread - even the new one. the only thing shown is the form to reply. odd.
if that gives you any ideas, please let me know, but i understand that it is some unknown issue relative to the theme and not privatemsg. thanks anyway for the help.
Comment #14
berdirIf you can give me access to the site by uploading to a public webserver or something like that, I can try it out myself and look what's happening with the CSS/Javascript in your theme. I don't think I can debug without access, since I don't have know what's happening behind the scenes in your theme.
Alternatively, it might be enough if you can send me your theme and I can try it on a local test site.
Comment #15
jaron commentedthanks for helping me with this.
i'm attaching the theme and will look into posting a version of the site. if you can find anything with the theme only, please let me know. is it possible it could be a conflict with another module?
thanks again.
Comment #16
berdirI can reproduce the issue with your theme. And I can fix it by removing "overflow: hidden" from #main. I'm not sure why it's doing that and you might need that property but that should give you a start...
Comment #17
jaron commentedgreat. thanks so much.
Comment #18
jaron commented