With the basic panels pane HTML you get a div like

<div class="panel-pane">
   ...pane html...
</div>

This is not unique enough to attach css to. More descriptive css classes would speed up theme development of a panels site.

CommentFileSizeAuthor
#3 panels-618624-3.patch1.1 KBjonskulski
#1 panels-618624.patch1.72 KBjonskulski

Comments

jonskulski’s picture

jonskulski commented
Status: Active » Needs review
StatusFileSize
new panels-618624.patch1.72 KB

We usually end up overriding the theme function to add specific classes. With the new template this is much much easier (which is woderful, btw).

We do this enough to warrant a patch. The code takes the subtype and type of the panel and turns them into css classes.

merlinofchaos’s picture

merlinofchaos commented

Maybe consider using the cleanstring tool to create class-safe rather than the simple _ to - conversion?

jonskulski’s picture

jonskulski commented
StatusFileSize
new panels-618624-3.patch1.1 KB

Rerolled using the ctool function

merlinofchaos’s picture

merlinofchaos commented
Status: Needs review » Fixed

Committed! THanks for the patch (and the patience)

jonskulski’s picture

jonskulski commented

Hey no worries, thanks for panels ;)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.