If you got broken revisions in your node table then the update process runs into an infinite loop.

Patch forthcoming.

CommentFileSizeAuthor
#1 infinite_loop.patch.txt7.05 KBkilles@www.drop.org
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

killes@www.drop.org’s picture

FileSize
7.05 KB
ultraBoy’s picture

Sorry, what "broken revisions" are? I have an idea about revisions, but what means "broken"?

killes@www.drop.org’s picture

In 4.6 and before revisions were stored as a serialized field. If for some reason this field can't be unserialized anymore, I refer to it as being broken.

beginner’s picture

ok. I have just been a victim of this bug.

Before I found the patch, I completed the upgrade by skipping update#159 and starting again at #160.

I don't really care about revisions, but do you think there is some clean up I should do?

Can I patch the file and run update#159 only? (later updates have all been completed).

thanks.

killes@www.drop.org’s picture

Version: 4.7.0 » x.y.z
Status: Active » Reviewed & tested by the community

Committed to 4.7

drumm’s picture

Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

urbanfalcon’s picture

Status: Fixed » Active

Having the same issue where the update dies at #159. I pulled a copy of the updates.inc file off CVS, too, so it should have had this patch already incorporated. I ended up having to remove my revisions in order to proceed. I would not doubt that some node revisions were serialized with errors. So the original assessment of death at #159 is still plausible for me, especially with a successful update after I emptied all revisions from the database. Unfortunately, my system has over 6000 nodes of information, so I don't know which node (or nodes) would be the culprit.

killes@www.drop.org’s picture

Are you sure your updates.inc has the patch? What is the cvs version at top of the file?

if you had the patch you would get watchdog erros about broken revisions.

urbanfalcon’s picture

Status: Active » Fixed

Hmm. I was at http://cvs.drupal.org/viewcvs/drupal/drupal/database/updates.inc?rev=1.2... but I must have clicked the wrong "download" button because my header says:

// $Id: updates.inc,v 1.227 2006/05/12 08:50:22 dries Exp $

I'll re-download and confirm v.1.230 before attempting the final site update (I was just testing via a dev copy before). Thanks!

Jennifer

Anonymous’s picture

Status: Fixed » Closed (fixed)