This looks like a dupe of http://drupal.org/project/adminrole.

It is slightly different, but seems like it should either be folded in or abandoned to avoid confusion. Whattya think?

Comments

cafuego’s picture

Not sure, adminrole seems to provide a way to turn on all perms for a single role only, not toggle all for each separate role.

greg.harvey’s picture

Title: Duplicate of Adminrole » Duplicate of Permission Select -> move to merge modules and use checkall module to provide checkboxes

I don't think it's the same as adminrole - adminrole is useful, but sometimes you want to REVOKE all permissions, e.g. remove permissions automatically assigned to anon.

Since a load of modules have emerged as a result of this one being release, I think it's a good opportunity to consolidate a few modules. There is the excellent checkall module which extends the Form API to allow a "check all" box on all forms:
http://drupal.org/project/checkall

There is also the Permission Select module, which does the same thing but also doesn't use checkall:
http://drupal.org/project/permission_select

I would suggest the permission_select and allperms modules should be rolled in to one and use the checkall Form API extension to achieve the functionality.

Orrrr, both modules should be revoked in exchange for a patch to the checkall module allowing users to (via a simple admin page) enable checkall in certain useful places by default (e.g. permissions).

What do you think, Mr Maintainer? =)

psynaptic’s picture

I couldn't agree more. One of the main principles of Drupal is collaboration. Don't duplicate work!

Please work with the maintainers of the other modules to come up with a solution to this. I like the intuitive interface provided by checkall.

greg.harvey’s picture

I would just like to add I feel for cafuego here - it's a good module and it is WAY too easy at the moment to not find suitable contrib, even if you spend a few hours looking, and think you have to write something to achieve some functionality. I've been there before and it's annoying to release a useful module then have a bunch of people say you've done a bad thing.

So, appreciate the effort! And if you hadn't done this, this conversation wouldn't have started and other projects might not be moved forward, so don't take it personally or feel like we don't appreciate it. Let's take this opportunity to get checkall, allperms and permission_select rolled in to one kick-ass checkall module. =)

jp.stacey’s picture

Yes, +1 for cafuego. The only way to get an idea of what's in contrib seems to be to sit on the new modules feed for, like, six months.

I like greg.harvey's idea: roll allperms and permission select together, and sit it on top of checkall. I wouldn't want to make the admin functionality an adjunct to what's basically a form element extension module, though - it seems a slightly odd mixture - so I'd keep the combined module separate from checkall with just a dependency in the .info file.

greg.harvey’s picture

OMG, another one!
http://drupal.org/project/check_heavy_ui

Seems this problem has been solved several times and I didn't know about any of them. =(

cafuego’s picture

I have nothing against rolling the functionality into a single module and using checkall in principle, but that does mean an extra module depend for such a small bit of extra functionality. That's fine for others, but for my own use I much prefer something tiny and stand-alone.

lpalgarvio’s picture

hey

there are a lot of permission UI modules around. naming some:
filter_perms
permission_select
check_heavy_ui
allperms
better_perms

are there plans to merge them together?

and what about a D7 port?

cafuego’s picture

Status: Active » Postponed

I don't currently have plans to merge or do a D7 port.