I just noticed, that there is a section called "messages" in core which contains one single function: http://api.drupal.org/api/HEAD/function/message_na

I really think that this one is pretty unnecessary. I attached a patch where all occurences of this function have been replaced with t('n/a').

CommentFileSizeAuthor
#5 message_na_contrib.patch23.08 KBkkaefer
#1 message_na_0.patch3.71 KBkkaefer
message_na.patch3.43 KBkkaefer

Comments

kkaefer’s picture

kkaefer commented
StatusFileSize
new message_na_0.patch3.71 KB

I still don't see any reason why this function should stay there. Updated the patch.

kkaefer’s picture

kkaefer commented
Status: Active » Needs review
fgm’s picture

fgm
Primary language French
Location Paris, France
commented

It is currently in use in various modules, some of them important. Removing it would mean patching them too:

  • locale.inc
  • blogapi.module
  • filter.module
  • forum.module
  • cvs.module
  • evaluation.module
  • filtercache.module
  • naggregator.module
  • subversion.module
  • theme: civicspace
  • berkes' node_aggregator
  • factoryjoe's groundswell theme
  • jsend's drupal4blog
  • killes' "speed drupal" filter.module
dries’s picture

dries commented
Status: Needs review » Needs work

Committed to CVS HEAD. Marking this 'code needs work'. Set to 'fixed' when this change is documented in the upgrade instructions. Thanks timcn.

kkaefer’s picture

kkaefer commented
StatusFileSize
new message_na_contrib.patch23.08 KB

Made a patch for contrib CVS to replace message_na() with t('n/a'). This should not break anything, even with non-HEAD versions.

kkaefer’s picture

kkaefer commented
Status: Needs work » Needs review

Thanks to killes, the change is no documented on the corresponding handbook page.

dries’s picture

dries commented
Status: Needs review » Fixed
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)